mirror of
https://github.com/bevyengine/bevy
synced 2024-11-30 00:20:20 +00:00
a60fe30ada
# Objective
- Avoid usages of `format!` that ~immediately get passed to another `format!`. This avoids a temporary allocation and is just generally cleaner.
## Solution
- `bevy_derive::shader_defs` does a `format!("{}", val.to_string())`, which is better written as just `format!("{}", val)`
- `bevy_diagnostic::log_diagnostics_plugin` does a `format!("{:>}", format!(...))`, which is better written as `format!("{:>}", format_args!(...))`
- `bevy_ecs::schedule` does `tracing::info!(..., name = &*format!("{:?}", val))`, which is better written with the tracing shorthand `tracing::info!(..., name = ?val)`
- `bevy_reflect::reflect` does `f.write_str(&format!(...))`, which is better written as `write!(f, ...)` (this could also be written using `f.debug_tuple`, but I opted to maintain alt debug behavior)
- `bevy_reflect::serde::{ser, de}` do `serde::Error::custom(format!(...))`, which is better written as `Error::custom(format_args!(...))`, as `Error::custom` takes `impl Display` and just immediately calls `format!` again
|
||
|---|---|---|
| .. | ||
| impls | ||
| serde | ||
| lib.rs | ||
| list.rs | ||
| map.rs | ||
| path.rs | ||
| reflect.rs | ||
| struct_trait.rs | ||
| tuple.rs | ||
| tuple_struct.rs | ||
| type_registry.rs | ||
| type_uuid.rs | ||