mirror of
https://github.com/bevyengine/bevy
synced 2024-11-24 21:53:07 +00:00
b1273d48cb
Enabled `check-private-items` in `clippy.toml` and then fixed the resulting errors. Most of these were simply misformatted and of the remaining: - ~Added `#[allow(clippy::missing_safety_doc)]` to~ Removed unsafe from a pair of functions in `bevy_utils/futures` which are only unsafe so that they can be passed to a function which requires `unsafe fn` - Removed `unsafe` from `UnsafeWorldCell::observers` as from what I can tell it is always safe like `components`, `bundles` etc. (this should be checked) - Added safety docs to: - `Bundles::get_storage_unchecked`: Based on the function that writes to `dynamic_component_storages` - `Bundles::get_storages_unchecked`: Based on the function that writes to `dynamic_bundle_storages` - `QueryIterationCursor::init_empty`: Duplicated from `init` - `QueryIterationCursor::peek_last`: Thanks Giooschi (also added internal unsafe blocks) - `tests::drop_ptr`: Moved safety comment out to the doc string This lint would also apply to `missing_errors_doc`, `missing_panics_doc` and `unnecessary_safety_doc` if we chose to enable any of those at some point, although there is an open [issue](https://github.com/rust-lang/rust-clippy/issues/13074) to separate these options.
44 lines
2.7 KiB
TOML
44 lines
2.7 KiB
TOML
doc-valid-idents = [
|
|
"GilRs",
|
|
"glTF",
|
|
"macOS",
|
|
"NVidia",
|
|
"OpenXR",
|
|
"sRGB",
|
|
"VSync",
|
|
"WebGL2",
|
|
"WebGPU",
|
|
"..",
|
|
]
|
|
|
|
check-private-items = true
|
|
|
|
disallowed-methods = [
|
|
{ path = "f32::powi", reason = "use bevy_math::ops::FloatPow::squared, bevy_math::ops::FloatPow::cubed, or bevy_math::ops::powf instead for libm determinism" },
|
|
{ path = "f32::log", reason = "use bevy_math::ops::ln, bevy_math::ops::log2, or bevy_math::ops::log10 instead for libm determinism" },
|
|
{ path = "f32::abs_sub", reason = "deprecated and deeply confusing method" },
|
|
{ path = "f32::powf", reason = "use bevy_math::ops::powf instead for libm determinism" },
|
|
{ path = "f32::exp", reason = "use bevy_math::ops::exp instead for libm determinism" },
|
|
{ path = "f32::exp2", reason = "use bevy_math::ops::exp2 instead for libm determinism" },
|
|
{ path = "f32::ln", reason = "use bevy_math::ops::ln instead for libm determinism" },
|
|
{ path = "f32::log2", reason = "use bevy_math::ops::log2 instead for libm determinism" },
|
|
{ path = "f32::log10", reason = "use bevy_math::ops::log10 instead for libm determinism" },
|
|
{ path = "f32::cbrt", reason = "use bevy_math::ops::cbrt instead for libm determinism" },
|
|
{ path = "f32::hypot", reason = "use bevy_math::ops::hypot instead for libm determinism" },
|
|
{ path = "f32::sin", reason = "use bevy_math::ops::sin instead for libm determinism" },
|
|
{ path = "f32::cos", reason = "use bevy_math::ops::cos instead for libm determinism" },
|
|
{ path = "f32::tan", reason = "use bevy_math::ops::tan instead for libm determinism" },
|
|
{ path = "f32::asin", reason = "use bevy_math::ops::asin instead for libm determinism" },
|
|
{ path = "f32::acos", reason = "use bevy_math::ops::acos instead for libm determinism" },
|
|
{ path = "f32::atan", reason = "use bevy_math::ops::atan instead for libm determinism" },
|
|
{ path = "f32::atan2", reason = "use bevy_math::ops::atan2 instead for libm determinism" },
|
|
{ path = "f32::sin_cos", reason = "use bevy_math::ops::sin_cos instead for libm determinism" },
|
|
{ path = "f32::exp_m1", reason = "use bevy_math::ops::exp_m1 instead for libm determinism" },
|
|
{ path = "f32::ln_1p", reason = "use bevy_math::ops::ln_1p instead for libm determinism" },
|
|
{ path = "f32::sinh", reason = "use bevy_math::ops::sinh instead for libm determinism" },
|
|
{ path = "f32::cosh", reason = "use bevy_math::ops::cosh instead for libm determinism" },
|
|
{ path = "f32::tanh", reason = "use bevy_math::ops::tanh instead for libm determinism" },
|
|
{ path = "f32::asinh", reason = "use bevy_math::ops::asinh instead for libm determinism" },
|
|
{ path = "f32::acosh", reason = "use bevy_math::ops::acosh instead for libm determinism" },
|
|
{ path = "f32::atanh", reason = "use bevy_math::ops::atanh instead for libm determinism" },
|
|
]
|