James Liu 958a898b4a Remove App::add_sub_app (#7290) ... # Objective Fixes #7286. Both `App::add_sub_app` and `App::insert_sub_app` are rather redundant. Before 0.10 is shipped, one of them should be removed. ## Solution Remove `App::add_sub_app` to prefer `App::insert_sub_app`. Also hid away `SubApp::extract` since that can be a footgun if someone mutates it for whatever reason. Willing to revert this change if there are objections. Perhaps we should make `SubApp: Deref<Target=App>`? Might change if we decide to move `!Send` resources into it. --- ## Changelog Added: `SubApp::new` Removed: `App::add_sub_app` ## Migration Guide `App::add_sub_app` has been removed in favor of `App::insert_sub_app`. Use `SubApp::new` and insert it via `App::add_sub_app` Old: ```rust let mut sub_app = App::new() // Build subapp here app.add_sub_app(MySubAppLabel, sub_app); ``` New: ```rust let mut sub_app = App::new() // Build subapp here app.insert_sub_app(MySubAppLabel, SubApp::new(sub_app, extract_fn)); ```		2023-01-24 21:24:25 +00:00
..
app.rs	Remove App::add_sub_app (#7290)	2023-01-24 21:24:25 +00:00
ci_testing.rs	Make Resource trait opt-in, requiring #[derive(Resource)] V2 (#5577)	2022-08-08 21:36:35 +00:00
lib.rs	Revert "Show prelude re-exports in docs (#6448)" (#6449)	2022-11-02 20:40:45 +00:00
plugin.rs	Separate Extract from Sub App Schedule (#7046)	2023-01-09 19:24:54 +00:00
plugin_group.rs	Unique plugin (#6411)	2022-10-31 16:12:19 +00:00
schedule_runner.rs	Docs: DefaultPlugins vs. MinimalPlugins and ScheduleRunnerPlugin (#7226)	2023-01-24 05:25:03 +00:00