mirror of
https://github.com/bevyengine/bevy
synced 2025-02-18 15:08:36 +00:00
1b444975ed
# Objective Fixes #7565 `ecs_guide` example is currently panicking. This seems to just be a problem with the example only caused by the base sets PR. ## Solution First, changed a few `in_set` to `in_base_set` to fix a few of ``` thread 'main' panicked at 'Systems cannot be added to 'base' system sets using 'in_set'. Use 'in_base_set' instead.', examples/ecs/ecs_guide.rs:301:45 ``` And then added an `in_base_set` to fix the resulting (confusing) cycle error ``` 2023-02-06T13:54:29.213843Z ERROR bevy_ecs::schedule_v3::schedule: schedule contains at least 1 cycle(s) -- cycle(s) found within: ---- 0: ["ecs_guide::game_over_system", "ecs_guide::score_check_system"] ``` I also changed this `add_system` call so the comment above and below make sense: ```diff // add_system(system) adds systems to the Update system set by default // However we can manually specify the set if we want to. The following is equivalent to // add_system(score_system) - .add_system(score_system) + .add_system(score_system.in_base_set(CoreSet::Update)) // There are other `CoreSets`, such as `Last` which runs at the very end of each run. ``` ## Notes - Does `MySet` even need to be a base set? Seems like yes. - Is that cycle error when there is no explicit `in_base_set` actually expected? |
||
|---|---|---|
| .. | ||
| component_change_detection.rs | ||
| custom_query_param.rs | ||
| ecs_guide.rs | ||
| event.rs | ||
| fixed_timestep.rs | ||
| generic_system.rs | ||
| hierarchy.rs | ||
| iter_combinations.rs | ||
| nondeterministic_system_order.rs | ||
| parallel_query.rs | ||
| removal_detection.rs | ||
| startup_system.rs | ||
| state.rs | ||
| system_closure.rs | ||
| system_param.rs | ||
| system_piping.rs | ||
| timers.rs | ||