mirror of
https://github.com/bevyengine/bevy
synced 2024-11-30 00:20:20 +00:00
01aedc8431
# Objective Now that we can consolidate Bundles and Components under a single insert (thanks to #2975 and #6039), almost 100% of world spawns now look like `world.spawn().insert((Some, Tuple, Here))`. Spawning an entity without any components is an extremely uncommon pattern, so it makes sense to give spawn the "first class" ergonomic api. This consolidated api should be made consistent across all spawn apis (such as World and Commands). ## Solution All `spawn` apis (`World::spawn`, `Commands:;spawn`, `ChildBuilder::spawn`, and `WorldChildBuilder::spawn`) now accept a bundle as input: ```rust // before: commands .spawn() .insert((A, B, C)); world .spawn() .insert((A, B, C); // after commands.spawn((A, B, C)); world.spawn((A, B, C)); ``` All existing instances of `spawn_bundle` have been deprecated in favor of the new `spawn` api. A new `spawn_empty` has been added, replacing the old `spawn` api. By allowing `world.spawn(some_bundle)` to replace `world.spawn().insert(some_bundle)`, this opened the door to removing the initial entity allocation in the "empty" archetype / table done in `spawn()` (and subsequent move to the actual archetype in `.insert(some_bundle)`). This improves spawn performance by over 10%: ![image](https://user-images.githubusercontent.com/2694663/191627587-4ab2f949-4ccd-4231-80eb-80dd4d9ad6b9.png) To take this measurement, I added a new `world_spawn` benchmark. Unfortunately, optimizing `Commands::spawn` is slightly less trivial, as Commands expose the Entity id of spawned entities prior to actually spawning. Doing the optimization would (naively) require assurances that the `spawn(some_bundle)` command is applied before all other commands involving the entity (which would not necessarily be true, if memory serves). Optimizing `Commands::spawn` this way does feel possible, but it will require careful thought (and maybe some additional checks), which deserves its own PR. For now, it has the same performance characteristics of the current `Commands::spawn_bundle` on main. **Note that 99% of this PR is simple renames and refactors. The only code that needs careful scrutiny is the new `World::spawn()` impl, which is relatively straightforward, but it has some new unsafe code (which re-uses battle tested BundlerSpawner code path).** --- ## Changelog - All `spawn` apis (`World::spawn`, `Commands:;spawn`, `ChildBuilder::spawn`, and `WorldChildBuilder::spawn`) now accept a bundle as input - All instances of `spawn_bundle` have been deprecated in favor of the new `spawn` api - World and Commands now have `spawn_empty()`, which is equivalent to the old `spawn()` behavior. ## Migration Guide ```rust // Old (0.8): commands .spawn() .insert_bundle((A, B, C)); // New (0.9) commands.spawn((A, B, C)); // Old (0.8): commands.spawn_bundle((A, B, C)); // New (0.9) commands.spawn((A, B, C)); // Old (0.8): let entity = commands.spawn().id(); // New (0.9) let entity = commands.spawn_empty().id(); // Old (0.8) let entity = world.spawn().id(); // New (0.9) let entity = world.spawn_empty(); ```
180 lines
5.6 KiB
Rust
180 lines
5.6 KiB
Rust
//! A custom post processing effect, using two cameras, with one reusing the render texture of the first one.
|
|
//! Here a chromatic aberration is applied to a 3d scene containing a rotating cube.
|
|
//! This example is useful to implement your own post-processing effect such as
|
|
//! edge detection, blur, pixelization, vignette... and countless others.
|
|
|
|
use bevy::{
|
|
core_pipeline::clear_color::ClearColorConfig,
|
|
prelude::*,
|
|
reflect::TypeUuid,
|
|
render::{
|
|
camera::RenderTarget,
|
|
render_resource::{
|
|
AsBindGroup, Extent3d, ShaderRef, TextureDescriptor, TextureDimension, TextureFormat,
|
|
TextureUsages,
|
|
},
|
|
texture::BevyDefault,
|
|
view::RenderLayers,
|
|
},
|
|
sprite::{Material2d, Material2dPlugin, MaterialMesh2dBundle},
|
|
};
|
|
|
|
fn main() {
|
|
App::new()
|
|
.add_plugins(DefaultPlugins)
|
|
.add_plugin(Material2dPlugin::<PostProcessingMaterial>::default())
|
|
.add_startup_system(setup)
|
|
.add_system(main_camera_cube_rotator_system)
|
|
.run();
|
|
}
|
|
|
|
/// Marks the first camera cube (rendered to a texture.)
|
|
#[derive(Component)]
|
|
struct MainCube;
|
|
|
|
fn setup(
|
|
mut commands: Commands,
|
|
mut windows: ResMut<Windows>,
|
|
mut meshes: ResMut<Assets<Mesh>>,
|
|
mut post_processing_materials: ResMut<Assets<PostProcessingMaterial>>,
|
|
mut materials: ResMut<Assets<StandardMaterial>>,
|
|
mut images: ResMut<Assets<Image>>,
|
|
) {
|
|
let window = windows.primary_mut();
|
|
let size = Extent3d {
|
|
width: window.physical_width(),
|
|
height: window.physical_height(),
|
|
..default()
|
|
};
|
|
|
|
// This is the texture that will be rendered to.
|
|
let mut image = Image {
|
|
texture_descriptor: TextureDescriptor {
|
|
label: None,
|
|
size,
|
|
dimension: TextureDimension::D2,
|
|
format: TextureFormat::bevy_default(),
|
|
mip_level_count: 1,
|
|
sample_count: 1,
|
|
usage: TextureUsages::TEXTURE_BINDING
|
|
| TextureUsages::COPY_DST
|
|
| TextureUsages::RENDER_ATTACHMENT,
|
|
},
|
|
..default()
|
|
};
|
|
|
|
// fill image.data with zeroes
|
|
image.resize(size);
|
|
|
|
let image_handle = images.add(image);
|
|
|
|
let cube_handle = meshes.add(Mesh::from(shape::Cube { size: 4.0 }));
|
|
let cube_material_handle = materials.add(StandardMaterial {
|
|
base_color: Color::rgb(0.8, 0.7, 0.6),
|
|
reflectance: 0.02,
|
|
unlit: false,
|
|
..default()
|
|
});
|
|
|
|
// The cube that will be rendered to the texture.
|
|
commands.spawn((
|
|
PbrBundle {
|
|
mesh: cube_handle,
|
|
material: cube_material_handle,
|
|
transform: Transform::from_translation(Vec3::new(0.0, 0.0, 1.0)),
|
|
..default()
|
|
},
|
|
MainCube,
|
|
));
|
|
|
|
// Light
|
|
// NOTE: Currently lights are ignoring render layers - see https://github.com/bevyengine/bevy/issues/3462
|
|
commands.spawn(PointLightBundle {
|
|
transform: Transform::from_translation(Vec3::new(0.0, 0.0, 10.0)),
|
|
..default()
|
|
});
|
|
|
|
// Main camera, first to render
|
|
commands.spawn(Camera3dBundle {
|
|
camera_3d: Camera3d {
|
|
clear_color: ClearColorConfig::Custom(Color::WHITE),
|
|
..default()
|
|
},
|
|
camera: Camera {
|
|
target: RenderTarget::Image(image_handle.clone()),
|
|
..default()
|
|
},
|
|
transform: Transform::from_translation(Vec3::new(0.0, 0.0, 15.0))
|
|
.looking_at(Vec3::default(), Vec3::Y),
|
|
..default()
|
|
});
|
|
|
|
// This specifies the layer used for the post processing camera, which will be attached to the post processing camera and 2d quad.
|
|
let post_processing_pass_layer = RenderLayers::layer((RenderLayers::TOTAL_LAYERS - 1) as u8);
|
|
|
|
let quad_handle = meshes.add(Mesh::from(shape::Quad::new(Vec2::new(
|
|
size.width as f32,
|
|
size.height as f32,
|
|
))));
|
|
|
|
// This material has the texture that has been rendered.
|
|
let material_handle = post_processing_materials.add(PostProcessingMaterial {
|
|
source_image: image_handle,
|
|
});
|
|
|
|
// Post processing 2d quad, with material using the render texture done by the main camera, with a custom shader.
|
|
commands.spawn((
|
|
MaterialMesh2dBundle {
|
|
mesh: quad_handle.into(),
|
|
material: material_handle,
|
|
transform: Transform {
|
|
translation: Vec3::new(0.0, 0.0, 1.5),
|
|
..default()
|
|
},
|
|
..default()
|
|
},
|
|
post_processing_pass_layer,
|
|
));
|
|
|
|
// The post-processing pass camera.
|
|
commands.spawn((
|
|
Camera2dBundle {
|
|
camera: Camera {
|
|
// renders after the first main camera which has default value: 0.
|
|
priority: 1,
|
|
..default()
|
|
},
|
|
..Camera2dBundle::default()
|
|
},
|
|
post_processing_pass_layer,
|
|
));
|
|
}
|
|
|
|
/// Rotates the cube rendered by the main camera
|
|
fn main_camera_cube_rotator_system(
|
|
time: Res<Time>,
|
|
mut query: Query<&mut Transform, With<MainCube>>,
|
|
) {
|
|
for mut transform in &mut query {
|
|
transform.rotate_x(0.55 * time.delta_seconds());
|
|
transform.rotate_z(0.15 * time.delta_seconds());
|
|
}
|
|
}
|
|
|
|
// Region below declares of the custom material handling post processing effect
|
|
|
|
/// Our custom post processing material
|
|
#[derive(AsBindGroup, TypeUuid, Clone)]
|
|
#[uuid = "bc2f08eb-a0fb-43f1-a908-54871ea597d5"]
|
|
struct PostProcessingMaterial {
|
|
/// In this example, this image will be the result of the main camera.
|
|
#[texture(0)]
|
|
#[sampler(1)]
|
|
source_image: Handle<Image>,
|
|
}
|
|
|
|
impl Material2d for PostProcessingMaterial {
|
|
fn fragment_shader() -> ShaderRef {
|
|
"shaders/custom_material_chromatic_aberration.wgsl".into()
|
|
}
|
|
}
|