mirror of
https://github.com/bevyengine/bevy
synced 2024-11-10 07:04:33 +00:00
bafffe1c5f
# Objective
I noticed some issues in `screenshot` example:
1. Cursor icon won't return from `SystemCursorIcon::Progress` to default
icon, even though screen shot saving is done.
2. Panics when exiting window: ``called `Result::unwrap()` on an `Err`
value:
NoEntities("bevy_ecs::query::state::QueryState<bevy_ecs::entity::Entity,
bevy_ecs::query::filter::With<bevy_window:🪟:Window>>")``
## Solution
1. Caused by cursor updating system not responding to [`CursorIcon`
component
removal](5cfcbf47ed/examples/window/screenshot.rs (L38)).
I believe it should, so change it to react to
`RemovedComponents<CursorIcon>`. (a suggestion)
2. Use `get_single` for window.
## Testing
- run screenshot example
---------
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
97 lines
2.6 KiB
Rust
97 lines
2.6 KiB
Rust
//! An example showing how to save screenshots to disk
|
|
|
|
use bevy::prelude::*;
|
|
use bevy::window::SystemCursorIcon;
|
|
use bevy_render::view::cursor::CursorIcon;
|
|
use bevy_render::view::screenshot::{save_to_disk, Capturing, Screenshot};
|
|
|
|
fn main() {
|
|
App::new()
|
|
.add_plugins(DefaultPlugins)
|
|
.add_systems(Startup, setup)
|
|
.add_systems(Update, (screenshot_on_spacebar, screenshot_saving))
|
|
.run();
|
|
}
|
|
|
|
fn screenshot_on_spacebar(
|
|
mut commands: Commands,
|
|
input: Res<ButtonInput<KeyCode>>,
|
|
mut counter: Local<u32>,
|
|
) {
|
|
if input.just_pressed(KeyCode::Space) {
|
|
let path = format!("./screenshot-{}.png", *counter);
|
|
*counter += 1;
|
|
commands
|
|
.spawn(Screenshot::primary_window())
|
|
.observe(save_to_disk(path));
|
|
}
|
|
}
|
|
|
|
fn screenshot_saving(
|
|
mut commands: Commands,
|
|
screenshot_saving: Query<Entity, With<Capturing>>,
|
|
windows: Query<Entity, With<Window>>,
|
|
) {
|
|
let Ok(window) = windows.get_single() else {
|
|
return;
|
|
};
|
|
match screenshot_saving.iter().count() {
|
|
0 => {
|
|
commands.entity(window).remove::<CursorIcon>();
|
|
}
|
|
x if x > 0 => {
|
|
commands
|
|
.entity(window)
|
|
.insert(CursorIcon::from(SystemCursorIcon::Progress));
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
|
|
/// set up a simple 3D scene
|
|
fn setup(
|
|
mut commands: Commands,
|
|
mut meshes: ResMut<Assets<Mesh>>,
|
|
mut materials: ResMut<Assets<StandardMaterial>>,
|
|
) {
|
|
// plane
|
|
commands.spawn(PbrBundle {
|
|
mesh: meshes.add(Plane3d::default().mesh().size(5.0, 5.0)),
|
|
material: materials.add(Color::srgb(0.3, 0.5, 0.3)),
|
|
..default()
|
|
});
|
|
// cube
|
|
commands.spawn(PbrBundle {
|
|
mesh: meshes.add(Cuboid::default()),
|
|
material: materials.add(Color::srgb(0.8, 0.7, 0.6)),
|
|
transform: Transform::from_xyz(0.0, 0.5, 0.0),
|
|
..default()
|
|
});
|
|
// light
|
|
commands.spawn(PointLightBundle {
|
|
point_light: PointLight {
|
|
shadows_enabled: true,
|
|
..default()
|
|
},
|
|
transform: Transform::from_xyz(4.0, 8.0, 4.0),
|
|
..default()
|
|
});
|
|
// camera
|
|
commands.spawn(Camera3dBundle {
|
|
transform: Transform::from_xyz(-2.0, 2.5, 5.0).looking_at(Vec3::ZERO, Vec3::Y),
|
|
..default()
|
|
});
|
|
|
|
commands.spawn(
|
|
TextBundle::from_section(
|
|
"Press <spacebar> to save a screenshot to disk",
|
|
TextStyle::default(),
|
|
)
|
|
.with_style(Style {
|
|
position_type: PositionType::Absolute,
|
|
top: Val::Px(12.0),
|
|
left: Val::Px(12.0),
|
|
..default()
|
|
}),
|
|
);
|
|
}
|