mirror of
https://github.com/bevyengine/bevy
synced 2024-12-21 10:33:08 +00:00
5ba2b9adcf
# Objective
Fixes these issues:
- `WorldId`s currently aren't necessarily unique
- I want to guarantee that they're unique to safeguard my librarified version of https://github.com/bevyengine/bevy/discussions/2805
- There probably hasn't been a collision yet, but they could technically collide
- `SystemId` isn't used for anything
- It's no longer used now that `Locals` are stored within the `System`.
- `bevy_ecs` depends on rand
## Solution
- Instead of randomly generating `WorldId`s, just use an incrementing atomic counter, panicing on overflow.
- Remove `SystemId`
- We do need to allow Locals for exclusive systems at some point, but exclusive systems couldn't access their own `SystemId` anyway.
- Now that these don't depend on rand, move it to a dev-dependency
## Todo
Determine if `WorldId` should be `u32` based instead
|
||
|---|---|---|
| .. | ||
| executor.rs | ||
| executor_parallel.rs | ||
| graph_utils.rs | ||
| label.rs | ||
| mod.rs | ||
| run_criteria.rs | ||
| stage.rs | ||
| state.rs | ||
| system_container.rs | ||
| system_descriptor.rs | ||
| system_set.rs | ||