2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-12-28 05:53:07 +00:00
bevy/examples/shader
Patrick Walton d3241c4f8d
Fix the texture_binding_array, specialized_mesh_pipeline, and custom_shader_instancing examples after the bindless change. ()
The bindless PR () broke some examples:

* `specialized_mesh_pipeline` and `custom_shader_instancing` failed
because they expect to be able to render a mesh with no material, by
overriding enough of the render pipeline to be able to do so. This PR
fixes the issue by restoring the old behavior in which we extract meshes
even if they have no material.

* `texture_binding_array` broke because it doesn't implement
`AsBindGroup::unprepared_bind_group`. This was tricky to fix because
there's a very good reason why `texture_binding_array` doesn't implement
that method: there's no sensible way to do so with `wgpu`'s current
bindless API, due to its multiple levels of borrowed references. To fix
the example, I split `MaterialBindGroup` into
`MaterialBindlessBindGroup` and `MaterialNonBindlessBindGroup`, and
allow direct custom implementations of `AsBindGroup::as_bind_group` for
the latter type of bind groups. To opt in to the new behavior, return
the `AsBindGroupError::CreateBindGroupDirectly` error from your
`AsBindGroup::unprepared_bind_group` implementation, and Bevy will call
your custom `AsBindGroup::as_bind_group` method as before.

## Migration Guide

* Bevy will now unconditionally call
`AsBindGroup::unprepared_bind_group` for your materials, so you must no
longer panic in that function. Instead, return the new
`AsBindGroupError::CreateBindGroupDirectly` error, and Bevy will fall
back to calling `AsBindGroup::as_bind_group` as before.
2024-12-05 21:22:14 +00:00
..
animate_shader.rs Migrate cameras to required components () 2024-10-05 01:59:52 +00:00
array_texture.rs Remove incorrect equality comparisons for asset load error types () 2024-10-14 01:00:45 +00:00
automatic_instancing.rs Migrate cameras to required components () 2024-10-05 01:59:52 +00:00
compute_shader_game_of_life.rs Expose Pipeline Compilation Zero Initialize Workgroup Memory Option () 2024-11-08 21:42:37 +00:00
custom_phase_item.rs Add a bindless mode to AsBindGroup. () 2024-12-03 18:00:34 +00:00
custom_post_processing.rs Don't reëxport bevy_image from bevy_render () 2024-11-10 06:54:38 +00:00
custom_shader_instancing.rs Deprecate SpatialBundle () 2024-10-13 17:28:22 +00:00
custom_vertex_attribute.rs Migrate cameras to required components () 2024-10-05 01:59:52 +00:00
extended_material.rs Place percentage-closer soft shadows behind a feature gate to save on samplers. () 2024-10-24 21:16:00 +00:00
fallback_image.rs Migrate cameras to required components () 2024-10-05 01:59:52 +00:00
gpu_readback.rs Don't reëxport bevy_image from bevy_render () 2024-11-10 06:54:38 +00:00
shader_defs.rs Migrate cameras to required components () 2024-10-05 01:59:52 +00:00
shader_material.rs Migrate cameras to required components () 2024-10-05 01:59:52 +00:00
shader_material_2d.rs Migrate cameras to required components () 2024-10-05 01:59:52 +00:00
shader_material_bindless.rs Add a bindless mode to AsBindGroup. () 2024-12-03 18:00:34 +00:00
shader_material_glsl.rs Migrate cameras to required components () 2024-10-05 01:59:52 +00:00
shader_material_screenspace_texture.rs aligning public apis of Time,Timer and Stopwatch () 2024-10-16 21:09:32 +00:00
shader_prepass.rs Merge Style properties into Node. Use ComputedNode for computed properties. () 2024-10-18 22:25:33 +00:00
specialized_mesh_pipeline.rs Add a bindless mode to AsBindGroup. () 2024-12-03 18:00:34 +00:00
storage_buffer.rs aligning public apis of Time,Timer and Stopwatch () 2024-10-16 21:09:32 +00:00
texture_binding_array.rs Fix the texture_binding_array, specialized_mesh_pipeline, and custom_shader_instancing examples after the bindless change. () 2024-12-05 21:22:14 +00:00