mirror of
https://github.com/bevyengine/bevy
synced 2024-11-26 06:30:19 +00:00
ace4c6023b
This commit implements a large subset of [*subpixel morphological antialiasing*], better known as SMAA. SMAA is a 2011 antialiasing technique that detects jaggies in an aliased image and smooths them out. Despite its age, it's been a continual staple of games for over a decade. Four quality presets are available: *low*, *medium*, *high*, and *ultra*. I set the default to *high*, on account of modern GPUs being significantly faster than they were in 2011. Like the already-implemented FXAA, SMAA works on an unaliased image. Unlike FXAA, it requires three passes: (1) edge detection; (2) blending weight calculation; (3) neighborhood blending. Each of the first two passes writes an intermediate texture for use by the next pass. The first pass also writes to a stencil buffer in order to dramatically reduce the number of pixels that the second pass has to examine. Also unlike FXAA, two built-in lookup textures are required; I bundle them into the library in compressed KTX2 format. The [reference implementation of SMAA] is in HLSL, with abundant use of preprocessor macros to achieve GLSL compatibility. Unfortunately, the reference implementation predates WGSL by over a decade, so I had to translate the HLSL to WGSL manually. As much as was reasonably possible without sacrificing readability, I tried to translate line by line, preserving comments, both to aid reviewing and to allow patches to the HLSL to more easily apply to the WGSL. Most of SMAA's features are supported, but in the interests of making this patch somewhat less huge, I skipped a few of the more exotic ones: * The temporal variant is currently unsupported. This is and has been used in shipping games, so supporting temporal SMAA would be useful follow-up work. It would, however, require some significant work on TAA to ensure compatibility, so I opted to skip it in this patch. * Depth- and chroma-based edge detection are unimplemented; only luma is. Depth is lower-quality, but faster; chroma is higher-quality, but slower. Luma is the suggested default edge detection algorithm. (Note that depth-based edge detection wouldn't work on WebGL 2 anyway, because of the Naga bug whereby depth sampling is miscompiled in GLSL. This is the same bug that prevents depth of field from working on that platform.) * Predicated thresholding is currently unsupported. * My implementation is incompatible with SSAA and MSAA, unlike the original; MSAA must be turned off to use SMAA in Bevy. I believe this feature was rarely used in practice. The `anti_aliasing` example has been updated to allow experimentation with and testing of the different SMAA quality presets. Along the way, I refactored the example's help text rendering code a bit to eliminate code repetition. SMAA is fully supported on WebGL 2. Fixes #9819. [*subpixel morphological antialiasing*]: https://www.iryoku.com/smaa/ [reference implementation of SMAA]: https://github.com/iryoku/smaa ## Changelog ### Added * Subpixel morphological antialiasing, or SMAA, is now available. To use it, add the `SmaaSettings` component to your `Camera`.  --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
37 lines
1.3 KiB
TOML
37 lines
1.3 KiB
TOML
[files]
|
|
extend-exclude = [
|
|
"*.pbxproj", # metadata file
|
|
"CHANGELOG.md", # To keep consistency between the commit history/PRs.
|
|
"*.patch", # Automatically generated files that should not be manually modified.
|
|
]
|
|
|
|
# Corrections take the form of a key/value pair. The key is the incorrect word
|
|
# and the value is the correct word. If the key and value are the same, the
|
|
# word is treated as always correct. If the value is an empty string, the word
|
|
# is treated as always incorrect.
|
|
|
|
# Match Whole Word - Case Sensitive
|
|
[default.extend-identifiers]
|
|
iy = "iy" # Variable name used in bevy_gizmos. Probably stands for "y-axis index", as it's being used in loops.
|
|
ser = "ser" # ron::ser - Serializer
|
|
SME = "SME" # Subject Matter Expert
|
|
Sur = "Sur" # macOS Big Sur - South
|
|
Masia = "Masia" # The surname of one of the authors of SMAA
|
|
Ba = "Ba" # Bitangent for Anisotropy
|
|
ba = "ba" # Part of an accessor in WGSL - color.ba
|
|
|
|
# Match Inside a Word - Case Insensitive
|
|
[default.extend-words]
|
|
LOD = "LOD" # Level of detail
|
|
TOI = "TOI" # Time of impact
|
|
|
|
[default]
|
|
extend-ignore-identifiers-re = [
|
|
"NDK", # NDK - Native Development Kit
|
|
"inventario", # Inventory in Portuguese
|
|
"PNG", # PNG - Portable Network Graphics file format
|
|
# Used in bevy_mikktspace
|
|
"iFO",
|
|
"vOt",
|
|
"fLenOt",
|
|
]
|