mirror of
https://github.com/bevyengine/bevy
synced 2024-12-24 12:03:14 +00:00
3d4e0066f4
# Objective Reduce the catch-all grab-bag of functionality in bevy_core by moving FloatOrd to bevy_utils. A step in addressing #2931 and splitting bevy_core into more specific locations. ## Solution Move FloatOrd into bevy_utils. Fix the compile errors. As a result, bevy_core_pipeline, bevy_pbr, bevy_sprite, bevy_text, and bevy_ui no longer depend on bevy_core (they were only using it for `FloatOrd` previously).
60 lines
1.6 KiB
Rust
60 lines
1.6 KiB
Rust
use std::{
|
|
cmp::Ordering,
|
|
hash::{Hash, Hasher},
|
|
ops::Neg,
|
|
};
|
|
|
|
/// A wrapper type that enables ordering floats. This is a work around for the famous "rust float
|
|
/// ordering" problem. By using it, you acknowledge that sorting NaN is undefined according to spec.
|
|
/// This implementation treats NaN as the "smallest" float.
|
|
#[derive(Debug, Copy, Clone, PartialOrd)]
|
|
pub struct FloatOrd(pub f32);
|
|
|
|
#[allow(clippy::derive_ord_xor_partial_ord)]
|
|
impl Ord for FloatOrd {
|
|
fn cmp(&self, other: &Self) -> Ordering {
|
|
self.0.partial_cmp(&other.0).unwrap_or_else(|| {
|
|
if self.0.is_nan() && !other.0.is_nan() {
|
|
Ordering::Less
|
|
} else if !self.0.is_nan() && other.0.is_nan() {
|
|
Ordering::Greater
|
|
} else {
|
|
Ordering::Equal
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
impl PartialEq for FloatOrd {
|
|
fn eq(&self, other: &Self) -> bool {
|
|
if self.0.is_nan() && other.0.is_nan() {
|
|
true
|
|
} else {
|
|
self.0 == other.0
|
|
}
|
|
}
|
|
}
|
|
|
|
impl Eq for FloatOrd {}
|
|
|
|
impl Hash for FloatOrd {
|
|
fn hash<H: Hasher>(&self, state: &mut H) {
|
|
if self.0.is_nan() {
|
|
// Ensure all NaN representations hash to the same value
|
|
state.write(&f32::to_ne_bytes(f32::NAN));
|
|
} else if self.0 == 0.0 {
|
|
// Ensure both zeroes hash to the same value
|
|
state.write(&f32::to_ne_bytes(0.0f32));
|
|
} else {
|
|
state.write(&f32::to_ne_bytes(self.0));
|
|
}
|
|
}
|
|
}
|
|
|
|
impl Neg for FloatOrd {
|
|
type Output = FloatOrd;
|
|
|
|
fn neg(self) -> Self::Output {
|
|
FloatOrd(-self.0)
|
|
}
|
|
}
|