mirror of
https://github.com/bevyengine/bevy
synced 2024-11-22 04:33:37 +00:00
2d1b4939d2
# Objective Fixes #15560 Fixes (most of) #15570 Currently a lot of examples (and presumably some user code) depend on toggling certain render features by adding/removing a single component to an entity, e.g. `SpotLight` to toggle a light. Because of the retained render world this no longer works: Extract will add any new components, but when it is removed the entity persists unchanged in the render world. ## Solution Add `SyncComponentPlugin<C: Component>` that registers `SyncToRenderWorld` as a required component for `C`, and adds a component hook that will clear all components from the render world entity when `C` is removed. We add this plugin to `ExtractComponentPlugin` which fixes most instances of the problem. For custom extraction logic we can manually add `SyncComponentPlugin` for that component. We also rename `WorldSyncPlugin` to `SyncWorldPlugin` so we start a naming convention like all the `Extract` plugins. In this PR I also fixed a bunch of breakage related to the retained render world, stemming from old code that assumed that `Entity` would be the same in both worlds. I found that using the `RenderEntity` wrapper instead of `Entity` in data structures when referring to render world entities makes intent much clearer, so I propose we make this an official pattern. ## Testing Run examples like ``` cargo run --features pbr_multi_layer_material_textures --example clearcoat cargo run --example volumetric_fog ``` and see that they work, and that toggles work correctly. But really we should test every single example, as we might not even have caught all the breakage yet. --- ## Migration Guide The retained render world notes should be updated to explain this edge case and `SyncComponentPlugin` --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Trashtalk217 <trashtalk217@gmail.com> |
||
|---|---|---|
| .. | ||
| 3d_scene.rs | ||
| 3d_shapes.rs | ||
| 3d_viewport_to_world.rs | ||
| animated_material.rs | ||
| anisotropy.rs | ||
| anti_aliasing.rs | ||
| atmospheric_fog.rs | ||
| auto_exposure.rs | ||
| blend_modes.rs | ||
| bloom_3d.rs | ||
| camera_sub_view.rs | ||
| clearcoat.rs | ||
| color_grading.rs | ||
| deferred_rendering.rs | ||
| depth_of_field.rs | ||
| fog.rs | ||
| fog_volumes.rs | ||
| generate_custom_mesh.rs | ||
| irradiance_volumes.rs | ||
| lighting.rs | ||
| lightmaps.rs | ||
| lines.rs | ||
| load_gltf.rs | ||
| load_gltf_extras.rs | ||
| meshlet.rs | ||
| motion_blur.rs | ||
| order_independent_transparency.rs | ||
| orthographic.rs | ||
| parallax_mapping.rs | ||
| parenting.rs | ||
| pbr.rs | ||
| pcss.rs | ||
| post_processing.rs | ||
| query_gltf_primitives.rs | ||
| reflection_probes.rs | ||
| render_to_texture.rs | ||
| rotate_environment_map.rs | ||
| scrolling_fog.rs | ||
| shadow_biases.rs | ||
| shadow_caster_receiver.rs | ||
| skybox.rs | ||
| spherical_area_lights.rs | ||
| split_screen.rs | ||
| spotlight.rs | ||
| ssao.rs | ||
| ssr.rs | ||
| texture.rs | ||
| tonemapping.rs | ||
| transmission.rs | ||
| transparency_3d.rs | ||
| two_passes.rs | ||
| update_gltf_scene.rs | ||
| vertex_colors.rs | ||
| visibility_range.rs | ||
| volumetric_fog.rs | ||
| wireframe.rs | ||