bevy/crates/bevy_mesh
Stepan Koltsov 1f69bc1f96
Mesh::merge: count_vertices instead of initializing positions (#16024)
# Objective

When merging two meshes, we need to find the offset of indices for the
second mesh. Currently it is done by inserting empty positions if
positions is not set.

Although practically it is not an issue, this does not feel right:
- We did not have positions before, then why we have positions after
merge?
- Moreover, if positions are not set, but uvs are not empty, computed
offset will be zero, while it should be equal to the number of uvs.

## Solution

Use `Mesh::count_vertices` to find the number of vertices.

## Testing

Looking hard.
2024-10-31 17:06:32 +00:00
..
src Mesh::merge: count_vertices instead of initializing positions (#16024) 2024-10-31 17:06:32 +00:00
Cargo.toml Remove thiserror from bevy_mesh (#15768) 2024-10-09 14:24:54 +00:00