mirror of
https://github.com/bevyengine/bevy
synced 2024-11-14 17:07:47 +00:00
26f7313212
As reported in #14004, many third-party plugins, such as Hanabi, enqueue entities that don't have meshes into render phases. However, the introduction of indirect mode added a dependency on mesh-specific data, breaking this workflow. This is because GPU preprocessing requires that the render phases manage indirect draw parameters, which don't apply to objects that aren't meshes. The existing code skips over binned entities that don't have indirect draw parameters, which causes the rendering to be skipped for such objects. To support this workflow, this commit adds a new field, `non_mesh_items`, to `BinnedRenderPhase`. This field contains a simple list of (bin key, entity) pairs. After drawing batchable and unbatchable objects, the non-mesh items are drawn one after another. Bevy itself doesn't enqueue any items into this list; it exists solely for the application and/or plugins to use. Additionally, this commit switches the asset ID in the standard bin keys to be an untyped asset ID rather than that of a mesh. This allows more flexibility, allowing bins to be keyed off any type of asset. This patch adds a new example, `custom_phase_item`, which simultaneously serves to demonstrate how to use this new feature and to act as a regression test so this doesn't break again. Fixes #14004. ## Changelog ### Added * `BinnedRenderPhase` now contains a `non_mesh_items` field for plugins to add custom items to. |
||
|---|---|---|
| .. | ||
| animate_shader.rs | ||
| array_texture.rs | ||
| compute_shader_game_of_life.rs | ||
| custom_phase_item.rs | ||
| custom_vertex_attribute.rs | ||
| extended_material.rs | ||
| fallback_image.rs | ||
| gpu_readback.rs | ||
| post_processing.rs | ||
| shader_defs.rs | ||
| shader_instancing.rs | ||
| shader_material.rs | ||
| shader_material_2d.rs | ||
| shader_material_glsl.rs | ||
| shader_material_screenspace_texture.rs | ||
| shader_prepass.rs | ||
| texture_binding_array.rs | ||