bevy/tools/example-showcase
Lura 856b39d821
Apply Clippy lints regarding lazy evaluation and closures (#14015)
# Objective

- Lazily evaluate
[default](https://rust-lang.github.io/rust-clippy/master/index.html#/unwrap_or_default)~~/[or](https://rust-lang.github.io/rust-clippy/master/index.html#/or_fun_call)~~
values where it makes sense
  - ~~`unwrap_or(foo())` -> `unwrap_or_else(|| foo())`~~
  - `unwrap_or(Default::default())` -> `unwrap_or_default()`
  - etc.
- Avoid creating [redundant
closures](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_closure),
even for [method
calls](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_closure_for_method_calls)
  - `map(|something| something.into())` -> `map(Into:into)`

## Solution

- Apply Clippy lints:
-
~~[or_fun_call](https://rust-lang.github.io/rust-clippy/master/index.html#/or_fun_call)~~
-
[unwrap_or_default](https://rust-lang.github.io/rust-clippy/master/index.html#/unwrap_or_default)
-
[redundant_closure_for_method_calls](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_closure_for_method_calls)
([redundant
closures](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_closure)
is already enabled)

## Testing

- Tested on Windows 11 (`stable-x86_64-pc-windows-gnu`, 1.79.0)
- Bevy compiles without errors or warnings and examples seem to work as
intended
  - `cargo clippy` 
  - `cargo run -p ci -- compile` 

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
2024-07-01 15:54:40 +00:00
..
src Apply Clippy lints regarding lazy evaluation and closures (#14015) 2024-07-01 15:54:40 +00:00
asset-source-website.patch Fix asset-source-website.patch line number (#13286) 2024-05-12 20:49:43 +00:00
Cargo.toml Shader code paths (#13908) 2024-06-19 03:23:02 +00:00
disable-audio.patch run examples on macOS to validate PRs (#11630) 2024-01-31 20:03:47 +00:00
extra-window-resized-events.patch fix: upgrade to winit v0.30 (#13366) 2024-06-03 13:06:48 +00:00
fixed-window-position.patch hacks for running (and screenshotting) the examples in CI on a github runner (#9220) 2023-10-13 19:19:17 +00:00
reduce-light-cluster-config.patch Regenerate light cluster patch file (#13655) 2024-06-03 18:19:32 +00:00
remove-desktop-app-mode.patch fix: upgrade to winit v0.30 (#13366) 2024-06-03 13:06:48 +00:00
window-settings-wasm.patch Fix example showcase wasm window settings patch (#12608) 2024-04-06 22:07:49 +00:00