mirror of
https://github.com/bevyengine/bevy
synced 2024-11-25 22:20:20 +00:00
4847f7e3ad
Remove unnecessary calls to `iter()`/`iter_mut()`.
Mainly updates the use of queries in our code, docs, and examples.
```rust
// From
for _ in list.iter() {
for _ in list.iter_mut() {
// To
for _ in &list {
for _ in &mut list {
```
We already enable the pedantic lint [clippy::explicit_iter_loop](https://rust-lang.github.io/rust-clippy/stable/) inside of Bevy. However, this only warns for a few known types from the standard library.
## Note for reviewers
As you can see the additions and deletions are exactly equal.
Maybe give it a quick skim to check I didn't sneak in a crypto miner, but you don't have to torture yourself by reading every line.
I already experienced enough pain making this PR :)
Co-authored-by: devil-ira <justthecooldude@gmail.com>
45 lines
1.3 KiB
Rust
45 lines
1.3 KiB
Rust
//! Renders a 2D scene containing a single, moving sprite.
|
|
|
|
use bevy::prelude::*;
|
|
|
|
fn main() {
|
|
App::new()
|
|
.add_plugins(DefaultPlugins)
|
|
.add_startup_system(setup)
|
|
.add_system(sprite_movement)
|
|
.run();
|
|
}
|
|
|
|
#[derive(Component)]
|
|
enum Direction {
|
|
Up,
|
|
Down,
|
|
}
|
|
|
|
fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
|
|
commands.spawn_bundle(Camera2dBundle::default());
|
|
commands
|
|
.spawn_bundle(SpriteBundle {
|
|
texture: asset_server.load("branding/icon.png"),
|
|
transform: Transform::from_xyz(100., 0., 0.),
|
|
..default()
|
|
})
|
|
.insert(Direction::Up);
|
|
}
|
|
|
|
/// The sprite is animated by changing its translation depending on the time that has passed since
|
|
/// the last frame.
|
|
fn sprite_movement(time: Res<Time>, mut sprite_position: Query<(&mut Direction, &mut Transform)>) {
|
|
for (mut logo, mut transform) in &mut sprite_position {
|
|
match *logo {
|
|
Direction::Up => transform.translation.y += 150. * time.delta_seconds(),
|
|
Direction::Down => transform.translation.y -= 150. * time.delta_seconds(),
|
|
}
|
|
|
|
if transform.translation.y > 200. {
|
|
*logo = Direction::Down;
|
|
} else if transform.translation.y < -200. {
|
|
*logo = Direction::Up;
|
|
}
|
|
}
|
|
}
|