mirror of
https://github.com/bevyengine/bevy
synced 2024-12-23 03:23:20 +00:00
44620dd6ae
# Objective Based on the discussion in #14864, I wanted to experiment with the core `GenericTypeCell` type, whose `get_or_insert` method accounted for 2% of the final binary size of the `3d_scene` example. The reason for this large percentage is likely because the type is fundamental to the rest of Bevy while having 3 generic parameters (the type stored `T`, the type to retrieve `G`, and the function used to insert a new value `F`). - Acts on #14864 ## Solution - Split `get_or_insert` into smaller functions with minimised parameterisation. These new functions are private as to preserve the public facing API, but could be exposed if desired. ## Testing - Ran CI locally. - Used `cargo bloat --release --example 3d_scene -n 100000 --message-format json > out.json` and @cart's [bloat analyzer](https://gist.github.com/cart/722756ba3da0e983d207633e0a48a8ab) to measure a 428KiB reduction in binary size when compiling on Windows 10. - ~I have _not_ benchmarked to determine if this improves/hurts performance.~ See [below](https://github.com/bevyengine/bevy/pull/14865#issuecomment-2306083606). ## Notes In my opinion this seems like a good test-case for the concept of debloating generics within the Bevy codebase. I believe the performance impact here is negligible in either direction (at runtime and compile time), but the binary reduction is measurable and quite significant for a relatively minor change in code. --------- Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| enums | ||
| func | ||
| impls | ||
| path | ||
| serde | ||
| array.rs | ||
| attributes.rs | ||
| fields.rs | ||
| from_reflect.rs | ||
| lib.rs | ||
| list.rs | ||
| map.rs | ||
| reflect.rs | ||
| remote.rs | ||
| set.rs | ||
| std_traits.rs | ||
| struct_trait.rs | ||
| tuple.rs | ||
| tuple_struct.rs | ||
| type_info.rs | ||
| type_path.rs | ||
| type_registry.rs | ||
| utility.rs | ||