mirror of
https://github.com/bevyengine/bevy
synced 2024-11-22 20:53:53 +00:00
dcc03724a5
# Objective NOTE: This depends on #7267 and should not be merged until #7267 is merged. If you are reviewing this before that is merged, I highly recommend viewing the Base Sets commit instead of trying to find my changes amongst those from #7267. "Default sets" as described by the [Stageless RFC](https://github.com/bevyengine/rfcs/pull/45) have some [unfortunate consequences](https://github.com/bevyengine/bevy/discussions/7365). ## Solution This adds "base sets" as a variant of `SystemSet`: A set is a "base set" if `SystemSet::is_base` returns `true`. Typically this will be opted-in to using the `SystemSet` derive: ```rust #[derive(SystemSet, Clone, Hash, Debug, PartialEq, Eq)] #[system_set(base)] enum MyBaseSet { A, B, } ``` **Base sets are exclusive**: a system can belong to at most one "base set". Adding a system to more than one will result in an error. When possible we fail immediately during system-config-time with a nice file + line number. For the more nested graph-ey cases, this will fail at the final schedule build. **Base sets cannot belong to other sets**: this is where the word "base" comes from Systems and Sets can only be added to base sets using `in_base_set`. Calling `in_set` with a base set will fail. As will calling `in_base_set` with a normal set. ```rust app.add_system(foo.in_base_set(MyBaseSet::A)) // X must be a normal set ... base sets cannot be added to base sets .configure_set(X.in_base_set(MyBaseSet::A)) ``` Base sets can still be configured like normal sets: ```rust app.add_system(MyBaseSet::B.after(MyBaseSet::Ap)) ``` The primary use case for base sets is enabling a "default base set": ```rust schedule.set_default_base_set(CoreSet::Update) // this will belong to CoreSet::Update by default .add_system(foo) // this will override the default base set with PostUpdate .add_system(bar.in_base_set(CoreSet::PostUpdate)) ``` This allows us to build apis that work by default in the standard Bevy style. This is a rough analog to the "default stage" model, but it use the new "stageless sets" model instead, with all of the ordering flexibility (including exclusive systems) that it provides. --- ## Changelog - Added "base sets" and ported CoreSet to use them. ## Migration Guide TODO |
||
|---|---|---|
| .. | ||
| 3d_scene.rs | ||
| 3d_shapes.rs | ||
| atmospheric_fog.rs | ||
| blend_modes.rs | ||
| bloom.rs | ||
| fog.rs | ||
| fxaa.rs | ||
| lighting.rs | ||
| lines.rs | ||
| load_gltf.rs | ||
| msaa.rs | ||
| orthographic.rs | ||
| parenting.rs | ||
| pbr.rs | ||
| render_to_texture.rs | ||
| shadow_biases.rs | ||
| shadow_caster_receiver.rs | ||
| skybox.rs | ||
| spherical_area_lights.rs | ||
| split_screen.rs | ||
| spotlight.rs | ||
| texture.rs | ||
| transparency_3d.rs | ||
| two_passes.rs | ||
| update_gltf_scene.rs | ||
| vertex_colors.rs | ||
| wireframe.rs | ||