mirror of
https://github.com/bevyengine/bevy
synced 2024-11-14 00:47:32 +00:00
aeeb20ec4c
# Objective **This implementation is based on https://github.com/bevyengine/rfcs/pull/59.** --- Resolves #4597 Full details and motivation can be found in the RFC, but here's a brief summary. `FromReflect` is a very powerful and important trait within the reflection API. It allows Dynamic types (e.g., `DynamicList`, etc.) to be formed into Real ones (e.g., `Vec<i32>`, etc.). This mainly comes into play concerning deserialization, where the reflection deserializers both return a `Box<dyn Reflect>` that almost always contain one of these Dynamic representations of a Real type. To convert this to our Real type, we need to use `FromReflect`. It also sneaks up in other ways. For example, it's a required bound for `T` in `Vec<T>` so that `Vec<T>` as a whole can be made `FromReflect`. It's also required by all fields of an enum as it's used as part of the `Reflect::apply` implementation. So in other words, much like `GetTypeRegistration` and `Typed`, it is very much a core reflection trait. The problem is that it is not currently treated like a core trait and is not automatically derived alongside `Reflect`. This makes using it a bit cumbersome and easy to forget. ## Solution Automatically derive `FromReflect` when deriving `Reflect`. Users can then choose to opt-out if needed using the `#[reflect(from_reflect = false)]` attribute. ```rust #[derive(Reflect)] struct Foo; #[derive(Reflect)] #[reflect(from_reflect = false)] struct Bar; fn test<T: FromReflect>(value: T) {} test(Foo); // <-- OK test(Bar); // <-- Panic! Bar does not implement trait `FromReflect` ``` #### `ReflectFromReflect` This PR also automatically adds the `ReflectFromReflect` (introduced in #6245) registration to the derived `GetTypeRegistration` impl— if the type hasn't opted out of `FromReflect` of course. <details> <summary><h4>Improved Deserialization</h4></summary> > **Warning** > This section includes changes that have since been descoped from this PR. They will likely be implemented again in a followup PR. I am mainly leaving these details in for archival purposes, as well as for reference when implementing this logic again. And since we can do all the above, we might as well improve deserialization. We can now choose to deserialize into a Dynamic type or automatically convert it using `FromReflect` under the hood. `[Un]TypedReflectDeserializer::new` will now perform the conversion and return the `Box`'d Real type. `[Un]TypedReflectDeserializer::new_dynamic` will work like what we have now and simply return the `Box`'d Dynamic type. ```rust // Returns the Real type let reflect_deserializer = UntypedReflectDeserializer::new(®istry); let mut deserializer = ron:🇩🇪:Deserializer::from_str(input)?; let output: SomeStruct = reflect_deserializer.deserialize(&mut deserializer)?.take()?; // Returns the Dynamic type let reflect_deserializer = UntypedReflectDeserializer::new_dynamic(®istry); let mut deserializer = ron:🇩🇪:Deserializer::from_str(input)?; let output: DynamicStruct = reflect_deserializer.deserialize(&mut deserializer)?.take()?; ``` </details> --- ## Changelog * `FromReflect` is now automatically derived within the `Reflect` derive macro * This includes auto-registering `ReflectFromReflect` in the derived `GetTypeRegistration` impl * ~~Renamed `TypedReflectDeserializer::new` and `UntypedReflectDeserializer::new` to `TypedReflectDeserializer::new_dynamic` and `UntypedReflectDeserializer::new_dynamic`, respectively~~ **Descoped** * ~~Changed `TypedReflectDeserializer::new` and `UntypedReflectDeserializer::new` to automatically convert the deserialized output using `FromReflect`~~ **Descoped** ## Migration Guide * `FromReflect` is now automatically derived within the `Reflect` derive macro. Items with both derives will need to remove the `FromReflect` one. ```rust // OLD #[derive(Reflect, FromReflect)] struct Foo; // NEW #[derive(Reflect)] struct Foo; ``` If using a manual implementation of `FromReflect` and the `Reflect` derive, users will need to opt-out of the automatic implementation. ```rust // OLD #[derive(Reflect)] struct Foo; impl FromReflect for Foo {/* ... */} // NEW #[derive(Reflect)] #[reflect(from_reflect = false)] struct Foo; impl FromReflect for Foo {/* ... */} ``` <details> <summary><h4>Removed Migrations</h4></summary> > **Warning** > This section includes changes that have since been descoped from this PR. They will likely be implemented again in a followup PR. I am mainly leaving these details in for archival purposes, as well as for reference when implementing this logic again. * The reflect deserializers now perform a `FromReflect` conversion internally. The expected output of `TypedReflectDeserializer::new` and `UntypedReflectDeserializer::new` is no longer a Dynamic (e.g., `DynamicList`), but its Real counterpart (e.g., `Vec<i32>`). ```rust let reflect_deserializer = UntypedReflectDeserializer::new_dynamic(®istry); let mut deserializer = ron:🇩🇪:Deserializer::from_str(input)?; // OLD let output: DynamicStruct = reflect_deserializer.deserialize(&mut deserializer)?.take()?; // NEW let output: SomeStruct = reflect_deserializer.deserialize(&mut deserializer)?.take()?; ``` Alternatively, if this behavior isn't desired, use the `TypedReflectDeserializer::new_dynamic` and `UntypedReflectDeserializer::new_dynamic` methods instead: ```rust // OLD let reflect_deserializer = UntypedReflectDeserializer::new(®istry); // NEW let reflect_deserializer = UntypedReflectDeserializer::new_dynamic(®istry); ``` </details> --------- Co-authored-by: Carter Anderson <mcanders1@gmail.com>
110 lines
4.3 KiB
Rust
110 lines
4.3 KiB
Rust
//! Illustrates how "reflection" works in Bevy.
|
|
//!
|
|
//! Reflection provides a way to dynamically interact with Rust types, such as accessing fields
|
|
//! by their string name. Reflection is a core part of Bevy and enables a number of interesting
|
|
//! features (like scenes).
|
|
|
|
use bevy::{
|
|
prelude::*,
|
|
reflect::{
|
|
serde::{ReflectSerializer, UntypedReflectDeserializer},
|
|
DynamicStruct,
|
|
},
|
|
};
|
|
use serde::de::DeserializeSeed;
|
|
|
|
fn main() {
|
|
App::new()
|
|
.add_plugins(DefaultPlugins)
|
|
.register_type::<Foo>()
|
|
.register_type::<Bar>()
|
|
.add_systems(Startup, setup)
|
|
.run();
|
|
}
|
|
|
|
/// Deriving `Reflect` implements the relevant reflection traits. In this case, it implements the
|
|
/// `Reflect` trait and the `Struct` trait `derive(Reflect)` assumes that all fields also implement
|
|
/// Reflect.
|
|
///
|
|
/// All fields in a reflected item will need to be `Reflect` as well. You can opt a field out of
|
|
/// reflection by using the `#[reflect(ignore)]` attribute.
|
|
/// If you choose to ignore a field, you need to let the automatically-derived `FromReflect` implementation
|
|
/// how to handle the field.
|
|
/// To do this, you can either define a `#[reflect(default = "...")]` attribute on the ignored field, or
|
|
/// opt-out of `FromReflect`'s auto-derive using the `#[reflect(from_reflect = false)]` attribute.
|
|
#[derive(Reflect)]
|
|
#[reflect(from_reflect = false)]
|
|
pub struct Foo {
|
|
a: usize,
|
|
nested: Bar,
|
|
#[reflect(ignore)]
|
|
_ignored: NonReflectedValue,
|
|
}
|
|
|
|
/// This `Bar` type is used in the `nested` field on the `Test` type. We must derive `Reflect` here
|
|
/// too (or ignore it)
|
|
#[derive(Reflect)]
|
|
pub struct Bar {
|
|
b: usize,
|
|
}
|
|
|
|
#[derive(Default)]
|
|
pub struct NonReflectedValue {
|
|
_a: usize,
|
|
}
|
|
|
|
fn setup(type_registry: Res<AppTypeRegistry>) {
|
|
let mut value = Foo {
|
|
a: 1,
|
|
_ignored: NonReflectedValue { _a: 10 },
|
|
nested: Bar { b: 8 },
|
|
};
|
|
|
|
// You can set field values like this. The type must match exactly or this will fail.
|
|
*value.get_field_mut("a").unwrap() = 2usize;
|
|
assert_eq!(value.a, 2);
|
|
assert_eq!(*value.get_field::<usize>("a").unwrap(), 2);
|
|
|
|
// You can also get the &dyn Reflect value of a field like this
|
|
let field = value.field("a").unwrap();
|
|
|
|
// you can downcast Reflect values like this:
|
|
assert_eq!(*field.downcast_ref::<usize>().unwrap(), 2);
|
|
|
|
// DynamicStruct also implements the `Struct` and `Reflect` traits.
|
|
let mut patch = DynamicStruct::default();
|
|
patch.insert("a", 4usize);
|
|
|
|
// You can "apply" Reflect implementations on top of other Reflect implementations.
|
|
// This will only set fields with the same name, and it will fail if the types don't match.
|
|
// You can use this to "patch" your types with new values.
|
|
value.apply(&patch);
|
|
assert_eq!(value.a, 4);
|
|
|
|
let type_registry = type_registry.read();
|
|
// By default, all derived `Reflect` types can be Serialized using serde. No need to derive
|
|
// Serialize!
|
|
let serializer = ReflectSerializer::new(&value, &type_registry);
|
|
let ron_string =
|
|
ron::ser::to_string_pretty(&serializer, ron::ser::PrettyConfig::default()).unwrap();
|
|
info!("{}\n", ron_string);
|
|
|
|
// Dynamic properties can be deserialized
|
|
let reflect_deserializer = UntypedReflectDeserializer::new(&type_registry);
|
|
let mut deserializer = ron::de::Deserializer::from_str(&ron_string).unwrap();
|
|
let reflect_value = reflect_deserializer.deserialize(&mut deserializer).unwrap();
|
|
|
|
// Deserializing returns a Box<dyn Reflect> value. Generally, deserializing a value will return
|
|
// the "dynamic" variant of a type. For example, deserializing a struct will return the
|
|
// DynamicStruct type. "Value types" will be deserialized as themselves.
|
|
let _deserialized_struct = reflect_value.downcast_ref::<DynamicStruct>();
|
|
|
|
// Reflect has its own `partial_eq` implementation, named `reflect_partial_eq`. This behaves
|
|
// like normal `partial_eq`, but it treats "dynamic" and "non-dynamic" types the same. The
|
|
// `Foo` struct and deserialized `DynamicStruct` are considered equal for this reason:
|
|
assert!(reflect_value.reflect_partial_eq(&value).unwrap());
|
|
|
|
// By "patching" `Foo` with the deserialized DynamicStruct, we can "Deserialize" Foo.
|
|
// This means we can serialize and deserialize with a single `Reflect` derive!
|
|
value.apply(&*reflect_value);
|
|
}
|