mirror of
https://github.com/bevyengine/bevy
synced 2024-11-22 12:43:34 +00:00
dd4d07dc9c
# Objective Make APIs more consistent and ergonomic by adding a `new` constructor for `Circle` and `Sphere`. This could be seen as a redundant "trivial constructor", but in practise, it seems valuable to me. I have lots of cases where formatting becomes ugly because of the lack of a constructor, like this: ```rust Circle { radius: self.radius(), } .contains_local_point(centered_pt) ``` With `new`, it'd be formatted much nicer: ```rust Circle::new(self.radius()).contains_local_point(centered_pt) ``` Of course, this is just one example, but my circle/sphere definitions very frequently span three or more lines when they could fit on one. Adding `new` also increases consistency. `Ellipse` has `new` already, and so does the mesh version of `Circle`. ## Solution Add a `new` constructor for `Circle` and `Sphere`. |
||
---|---|---|
.. | ||
src | ||
Cargo.toml |