Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-21 12:13:25 +00:00
Code Issues Projects Releases Packages Wiki Activity
bevy/tools/compile_fail_utils
History
Gino Valente f8ef767ab0
compile_fail_utils: Verify path exists (#14827) 
# Objective

It looks like running `compile_fail_utils::test` on an invalid path just
skips the test. I'm not sure why `ui_test` doesn't fail the test, but it
seems pretty easy to accidentally cause a test to be skipped (I
experienced
[this](https://github.com/bevyengine/bevy/pull/14813#discussion_r1721880973)
while doing some refactoring on `bevy_reflect`).

## Solution

Check to make sure the given path exists before continuing on with the
tests.

Alternatively, we could look into seeing why this doesn't work properly
upstream. But I figured this solution was simple enough just to
implement directly without having to worry about updating `ui_test`.

## Testing

To verify that this works as expected `cd` into
`crates/bevy_reflect/compile_fail`. Then run the following:

```
cargo test --target-dir ../../../target
```

All compile fail tests should pass. Now edit the path used in
`crates/bevy_reflect/compile_fail/tests/derive.rs`. For example:

```diff
fn main() -> compile_fail_utils::ui_test::Result<()> {
-    compile_fail_utils::test("reflect_derive", "tests/reflect_derive")
+    compile_fail_utils::test("reflect_derive", "tests/does_not_exist")
}
```

Run the tests again:

```
cargo test --target-dir ../../../target
```

Verify the test fails with an error like:

```
Error: path does not exist: "tests/does_not_exist"
```
2024-08-22 16:54:26 +00:00
..
src compile_fail_utils: Verify path exists (#14827) 2024-08-22 16:54:26 +00:00
tests Move compile fail tests (#13196) 2024-05-03 13:35:21 +00:00
Cargo.toml Update compile test to use ui_test 0.23 (#13245) 2024-05-05 22:17:56 +00:00
README.md Move compile fail tests (#13196) 2024-05-03 13:35:21 +00:00

README.md

Helpers for compile fail tests

This crate contains everything needed to set up compile tests for the Bevy repo. It, like all Bevy compile test crates, is excluded from the Bevy workspace. This is done to not fail crater tests for Bevy. The CI workflow executes these tests on the stable rust toolchain see (tools/ci).

Writing new test cases

Test cases are annotated .rs files. These annotations define how the test case should be run and what we're expecting to fail. Please see https://github.com/oli-obk/ui_test/blob/main/README.md for more information.

Annotations can roughly be split into global annotations which are prefixed with //@ and define how tests should be run and error annotations which are prefixed with //~ and define where errors we expect to happen. From the global annotations, you're only likely to care about //@check-pass which will make any compile errors in the test trigger a test failure.

The error annotations are composed of two parts. An optional location specifier:

  • ^ The error happens on the line above.
  • v The error happens on the line below.
  • | The error annotation is connected to another one.
  • If the location specifier is missing, the error is assumed to happen on the same line as the annotation.

An error matcher:

  • E#### The error we're expecting has the #### rustc error code, e.g E0499
  • <lint_name> The given compiler lint is triggered, e.g. dead_code
  • LEVEL: <substring> A compiler error of the given level (valid levels are: ERROR, HELP, WARN or NOTE) will be raised and it will contain the substring. Substrings can contain spaces.
  • LEVEL: /<regex>/ Same as above but a regex is used to match the error message.

An example of an error annotation would be //~v ERROR: missing trait. This error annotation will match any error occurring on the line below that contains the substring missing trait.

Adding compile fail tests for a crate that doesn't have them

This will be a rather involved process. You'll have to:

  • Create a subdirectory named compile_fail within the crate you are testing. (E.g. bevy_ecs/compile_fail for bevy_ecs.)
  • Add compile_fail_utils as a dev-dependency.
  • Create a folder called tests within the new crate.
  • Add a test runner file to this folder. The file should contain a main function calling one of the test functions defined in this crate.
  • Add a [[test]] table to the Cargo.toml. This table will need to contain harness = false and name = <name of the test runner file you defined>.
  • Add the path of the new crate under [workspace].exclude in the root Cargo.toml.
  • Modify the CI tool to run cargo test on this crate.
  • And finally, write your compile tests.

If you have any questions, don't be scared to ask for help.

A note about .stderr files

We're capable of generating .stderr files for all our compile tests. These files contain the error output generated by the test. To create or regenerate them yourself, trigger the tests with the BLESS environment variable set to any value (e.g. BLESS="some symbolic value"). We currently have to ignore mismatches between these files and the actual stderr output from their corresponding test due to issues with file paths. We attempt to sanitize file paths but for proc-macros, the compiler error messages contain file paths to the current toolchain's copy of the standard library. If we knew of a way to construct a path to the current toolchains folder we could fix this.