Mirrors/bevy

mirror of https://github.com/bevyengine/bevy synced 2025-01-25 03:15:20 +00:00

Author SHA1 Message Date

Author	SHA1	Message	Date
Clar Fon	efda7f3f9c	Simpler lint fixes: makes `ci lints` work but disables a lint for now (#15376 ) Takes the first two commits from #15375 and adds suggestions from this comment: https://github.com/bevyengine/bevy/pull/15375#issuecomment-2366968300 See #15375 for more reasoning/motivation. ## Rebasing (rerunning) ```rust git switch simpler-lint-fixes git reset --hard main cargo fmt --all -- --unstable-features --config normalize_comments=true,imports_granularity=Crate cargo fmt --all git add --update git commit --message "rustfmt" cargo clippy --workspace --all-targets --all-features --fix cargo fmt --all -- --unstable-features --config normalize_comments=true,imports_granularity=Crate cargo fmt --all git add --update git commit --message "clippy" git cherry-pick e6c0b94f6795222310fb812fa5c4512661fc7887 ```	2024-09-24 11:42:59 +00:00
Lars Frost	dcbd30200e	Make names of closure systems changable (#14369 ) # Objective When using tracing or [`bevy_mod_debugdump`](https://github.com/jakobhellermann/bevy_mod_debugdump), the names of function systems produced by closures are either ambiguous (like `game::mainapp::{closure}` when tracing) or too long (`bevy_mod_debugdump` includes full type signature if no name given), which makes debugging with tracing difficult. ## Solution Add a function `with_name` to rename a system. The proposed API can be used in the following way: ```rust app .add_systems(Startup, IntoSystem::into_system(\|name: SystemName\| { println!("System name: {}", name.name().to_owned()); }).with_name("print_test_system")); ``` ## Testing - There is a test in `bevy_ecs::system:system_name::test_closure_system_name_regular_param`	2024-07-18 18:07:47 +00:00
Stepan Koltsov	6bc2686a7a	impl ExclusiveSystemParam for SystemName (#11163 ) # Objective `SystemName` might be useful in systems which accept `&mut World`. ## Solution - `impl ExclusiveSystemParam for SystemName` - move `SystemName` into a separate file, because it no longer belongs to a file which defines `SystemParam` - add a test for new impl, and for existing impl ## Changelog - `impl ExclusiveSystemParam for SystemName`	2024-01-01 17:08:29 +00:00

Clar Fon

efda7f3f9c

Simpler lint fixes: makes ci lints work but disables a lint for now (#15376 )

Takes the first two commits from #15375 and adds suggestions from this
comment:
https://github.com/bevyengine/bevy/pull/15375#issuecomment-2366968300

See #15375 for more reasoning/motivation.

## Rebasing (rerunning)

```rust
git switch simpler-lint-fixes
git reset --hard main
cargo fmt --all -- --unstable-features --config normalize_comments=true,imports_granularity=Crate
cargo fmt --all
git add --update
git commit --message "rustfmt"
cargo clippy --workspace --all-targets --all-features --fix
cargo fmt --all -- --unstable-features --config normalize_comments=true,imports_granularity=Crate
cargo fmt --all
git add --update
git commit --message "clippy"
git cherry-pick e6c0b94f6795222310fb812fa5c4512661fc7887
```

2024-09-24 11:42:59 +00:00

Lars Frost

dcbd30200e

Make names of closure systems changable (#14369 )

# Objective

When using tracing or
[`bevy_mod_debugdump`](https://github.com/jakobhellermann/bevy_mod_debugdump),
the names of function systems produced by closures are either ambiguous
(like `game::mainapp::{closure}` when tracing) or too long
(`bevy_mod_debugdump` includes full type signature if no name given),
which makes debugging with tracing difficult.

## Solution
Add a function `with_name` to rename a system. The proposed API can be
used in the following way:
```rust
app
    .add_systems(Startup, IntoSystem::into_system(|name: SystemName| {
        println!("System name: {}", name.name().to_owned());
    }).with_name("print_test_system"));
```

## Testing
- There is a test in
`bevy_ecs::system:system_name::test_closure_system_name_regular_param`

2024-07-18 18:07:47 +00:00

Stepan Koltsov

6bc2686a7a

impl ExclusiveSystemParam for SystemName (#11163 )

# Objective

`SystemName` might be useful in systems which accept `&mut World`.

## Solution

- `impl ExclusiveSystemParam for SystemName`
- move `SystemName` into a separate file, because it no longer belongs
to a file which defines `SystemParam`
- add a test for new impl, and for existing impl

## Changelog

- `impl ExclusiveSystemParam for SystemName`

2024-01-01 17:08:29 +00:00

3 commits