Mirrors/bevy

Fork 0

mirror of https://github.com/bevyengine/bevy synced 2025-01-08 03:08:55 +00:00

Commit graph

Author	SHA1	Message	Date
lambdagolem	8bc7320a35	Fix typo in Xtask CI (#1526 ) I think there was a typo here. If this is not a typo and I misunderstood the comment please just ignore this PR.	2021-03-03 23:36:00 +00:00
Nathan Stocks	13b602ee3f	Xtask CI (#1387 ) This PR is easiest to review commit by commit. Followup on https://github.com/bevyengine/bevy/pull/1309#issuecomment-767310084 - [x] Switch from a bash script to an xtask rust workspace member. - Results in ~30s longer CI due to compilation of the xtask itself - Enables Bevy contributors on any platform to run `cargo ci` to run linting -- if the default available Rust is the same version as on CI, then the command should give an identical result. - [x] Use the xtask from official CI so there's only one place to update. - [x] Bonus: Run clippy on the _entire_ workspace (existing CI setup was missing the `--workspace` flag - [x] Clean up newly-exposed clippy errors ~#1388 builds on this to clean up newly discovered clippy errors -- I thought it might be nicer as a separate PR.~ Nope, merged it into this one so CI would pass. Co-authored-by: Carter Anderson <mcanders1@gmail.com>	2021-02-22 08:42:19 +00:00

Author

SHA1

Message

Date

lambdagolem

8bc7320a35

Fix typo in Xtask CI (#1526 )

I think there was a typo here. If this is not a typo and I misunderstood the comment please just ignore this PR.

2021-03-03 23:36:00 +00:00

Nathan Stocks

13b602ee3f

Xtask CI (#1387 )

This PR is easiest to review commit by commit.

Followup on https://github.com/bevyengine/bevy/pull/1309#issuecomment-767310084

- [x] Switch from a bash script to an xtask rust workspace member.
  - Results in ~30s longer CI due to compilation of the xtask itself
  - Enables Bevy contributors on any platform to run `cargo ci` to run linting -- if the default available Rust is the same version as on CI, then the command should give an identical result.
- [x] Use the xtask from official CI so there's only one place to update.
- [x] Bonus: Run clippy on the _entire_ workspace (existing CI setup was missing the `--workspace` flag
  - [x] Clean up newly-exposed clippy errors 

~#1388 builds on this to clean up newly discovered clippy errors -- I thought it might be nicer as a separate PR.~  Nope, merged it into this one so CI would pass.

Co-authored-by: Carter Anderson <mcanders1@gmail.com>

2021-02-22 08:42:19 +00:00

2 commits