Mirrors/bevy

mirror of https://github.com/bevyengine/bevy synced 2024-12-24 20:13:07 +00:00

Author SHA1 Message Date

Author	SHA1	Message	Date
2ne1ugly	0e9f80e00b	Implement `SparseSetIndex` for `WorldId` (#7125 ) # Objective - Fixes #7124 ## Solution - Add Hash Derive on `WorldId` - Add `SparseSetIndex` impl	2023-01-09 21:43:27 +00:00
Daniel McNab	5ba2b9adcf	Unique WorldId (#2827 ) # Objective Fixes these issues: - `WorldId`s currently aren't necessarily unique - I want to guarantee that they're unique to safeguard my librarified version of https://github.com/bevyengine/bevy/discussions/2805 - There probably hasn't been a collision yet, but they could technically collide - `SystemId` isn't used for anything - It's no longer used now that `Locals` are stored within the `System`. - `bevy_ecs` depends on rand ## Solution - Instead of randomly generating `WorldId`s, just use an incrementing atomic counter, panicing on overflow. - Remove `SystemId` - We do need to allow Locals for exclusive systems at some point, but exclusive systems couldn't access their own `SystemId` anyway. - Now that these don't depend on rand, move it to a dev-dependency ## Todo Determine if `WorldId` should be `u32` based instead	2021-09-30 20:54:47 +00:00

2ne1ugly

0e9f80e00b

Implement SparseSetIndex for WorldId (#7125 )

# Objective

- Fixes #7124

## Solution

- Add Hash Derive on `WorldId`
- Add `SparseSetIndex` impl

2023-01-09 21:43:27 +00:00

Daniel McNab

5ba2b9adcf

Unique WorldId (#2827 )

# Objective

Fixes these issues:
- `WorldId`s currently aren't necessarily unique
    - I want to guarantee that they're unique to safeguard my librarified version of https://github.com/bevyengine/bevy/discussions/2805
    - There probably hasn't been a collision yet, but they could technically collide
- `SystemId` isn't used for anything
  - It's no longer used now that `Locals` are stored within the `System`.
- `bevy_ecs` depends on rand

## Solution

- Instead of randomly generating `WorldId`s, just use an incrementing atomic counter, panicing on overflow.
- Remove `SystemId` 
    - We do need to allow Locals for exclusive systems at some point, but exclusive systems couldn't access their own `SystemId` anyway.
- Now that these don't depend on rand, move it to a dev-dependency

## Todo

Determine if `WorldId` should be `u32` based instead

2021-09-30 20:54:47 +00:00

2 commits