Check examples screenshots on windows (#16010)

# Objective

- Checks screenshots on Windows
- Progress towards #15918 

## Solution

- Checks screenshots on Windows
- Also disable the helmet gltf scene in windows ci as it doesn't work
This commit is contained in:
François Mockers 2024-10-20 16:58:35 +02:00 committed by GitHub
parent 34c9a64779
commit ec268420f7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 15 additions and 3 deletions

View file

@ -148,7 +148,8 @@ jobs:
secrets: inherit secrets: inherit
run-examples-on-windows-dx12: run-examples-on-windows-dx12:
if: ${{ github.event_name == 'merge_group' }} # also run when pushed to main to update reference screenshots
if: ${{ github.event_name != 'pull_request' }}
runs-on: windows-latest runs-on: windows-latest
timeout-minutes: 30 timeout-minutes: 30
steps: steps:
@ -191,6 +192,17 @@ jobs:
name: example-run-windows name: example-run-windows
path: example-run/ path: example-run/
compare-windows-screenshots:
name: Compare Windows screenshots
needs: [run-examples-on-windows-dx12]
uses: ./.github/workflows/send-screenshots-to-pixeleagle.yml
with:
commit: ${{ github.sha }}
branch: ${{ github.ref_name }}
artifact: screenshots-windows
os: windows
secrets: inherit
run-examples-on-wasm: run-examples-on-wasm:
if: ${{ github.event_name == 'merge_group' }} if: ${{ github.event_name == 'merge_group' }}
runs-on: ubuntu-22.04 runs-on: ubuntu-22.04

View file

@ -12,13 +12,13 @@ fn main() {
.init_state::<Scene>() .init_state::<Scene>()
.enable_state_scoped_entities::<Scene>() .enable_state_scoped_entities::<Scene>()
.add_systems(OnEnter(Scene::Light), light::setup) .add_systems(OnEnter(Scene::Light), light::setup)
.add_systems(OnEnter(Scene::Gltf), gltf::setup)
.add_systems(OnEnter(Scene::Animation), animation::setup) .add_systems(OnEnter(Scene::Animation), animation::setup)
.add_systems(Update, switch_scene); .add_systems(Update, switch_scene);
// Those scenes don't work in CI on Windows runners // Those scenes don't work in CI on Windows runners
#[cfg(not(all(feature = "bevy_ci_testing", target_os = "windows")))] #[cfg(not(all(feature = "bevy_ci_testing", target_os = "windows")))]
app.add_systems(OnEnter(Scene::Bloom), bloom::setup); app.add_systems(OnEnter(Scene::Bloom), bloom::setup)
.add_systems(OnEnter(Scene::Gltf), gltf::setup);
app.run(); app.run();
} }