Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-22 04:33:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

webgl feature renamed to webgl2 (#9370)

Browse source 
Addresses:
```sh
$ cargo build --release --example lighting --target wasm32-unknown-unknown --features webgl
error: none of the selected packages contains these features: webgl, did you mean: webgl2, webp?
```

# Objective

- When following the instructions for the web examples.
- Document clearly the generated file `./target/wasm_example.js`, since
it didn't appear on `git grep` (missing extension)

## Solution

- Follow the feature rename on the docs.

---------

Signed-off-by: Seb Ospina <kraige@gmail.com>
This commit is contained in:
Seb Ospina 2023-08-12 23:05:36 +02:00 committed by GitHub
parent ac8f36743e
commit e489dcc9e8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs-template/EXAMPLE_README.md.tpl
View file

@ -210,7 +210,7 @@ Following is an example for `lighting`. For other examples, change the `lighting
following commands. following commands.
```sh ```sh
cargo build --release --example lighting --target wasm32-unknown-unknown --features webgl cargo build --release --example lighting --target wasm32-unknown-unknown
wasm-bindgen --out-name wasm_example \ wasm-bindgen --out-name wasm_example \
--out-dir examples/wasm/target \ --out-dir examples/wasm/target \
--target web target/wasm32-unknown-unknown/release/examples/lighting.wasm --target web target/wasm32-unknown-unknown/release/examples/lighting.wasm
@ -218,7 +218,7 @@ wasm-bindgen --out-name wasm_example \
The first command will build the example for the wasm target, creating a binary. Then, The first command will build the example for the wasm target, creating a binary. Then,
[wasm-bindgen-cli](https://rustwasm.github.io/wasm-bindgen/reference/cli.html) is used to create [wasm-bindgen-cli](https://rustwasm.github.io/wasm-bindgen/reference/cli.html) is used to create
javascript bindings to this wasm file, which can be loaded using this javascript bindings to this wasm file in the output file `examples/wasm/target/wasm_example.js`, which can be loaded using this
[example HTML file](./wasm/index.html). [example HTML file](./wasm/index.html).
Then serve `examples/wasm` directory to browser. i.e. Then serve `examples/wasm` directory to browser. i.e.

4
examples/README.md
View file

@ -507,7 +507,7 @@ Following is an example for `lighting`. For other examples, change the `lighting
following commands. following commands.
```sh ```sh
cargo build --release --example lighting --target wasm32-unknown-unknown --features webgl cargo build --release --example lighting --target wasm32-unknown-unknown
wasm-bindgen --out-name wasm_example \ wasm-bindgen --out-name wasm_example \
--out-dir examples/wasm/target \ --out-dir examples/wasm/target \
--target web target/wasm32-unknown-unknown/release/examples/lighting.wasm --target web target/wasm32-unknown-unknown/release/examples/lighting.wasm
@ -515,7 +515,7 @@ wasm-bindgen --out-name wasm_example \
The first command will build the example for the wasm target, creating a binary. Then, The first command will build the example for the wasm target, creating a binary. Then,
[wasm-bindgen-cli](https://rustwasm.github.io/wasm-bindgen/reference/cli.html) is used to create [wasm-bindgen-cli](https://rustwasm.github.io/wasm-bindgen/reference/cli.html) is used to create
javascript bindings to this wasm file, which can be loaded using this javascript bindings to this wasm file in the output file `examples/wasm/target/wasm_example.js`, which can be loaded using this
[example HTML file](./wasm/index.html). [example HTML file](./wasm/index.html).
Then serve `examples/wasm` directory to browser. i.e. Then serve `examples/wasm` directory to browser. i.e.