mirror of
https://github.com/bevyengine/bevy
synced 2024-11-24 21:53:07 +00:00
Fix MIME type support for glTF buffer Data URIs (pipelined) (#3106)
Apply #3101 on top of the `pipelined-rendering` branch, as requested by @cart in https://github.com/bevyengine/bevy/pull/3101#issuecomment-965907267 # Objective - The glTF 2.0 spec requires that Data URIs use one of two valid MIME types. `bevy_gltf2` only supports one of these. - See: - https://www.khronos.org/registry/glTF/specs/2.0/glTF-2.0.html#_media_type_registrations - https://www.khronos.org/registry/glTF/specs/2.0/glTF-2.0.html#file-extensions-and-media-types - https://www.khronos.org/registry/glTF/specs/2.0/glTF-2.0.html#binary-data-storage > Buffer data **MAY** alternatively be embedded in the glTF file via `data:` URI with base64 encoding. When `data:` URI is used for buffer storage, its mediatype field **MUST** be set to `application/octet-stream` or `application/gltf-buffer`. (Emphasis in original.) ## Solution - Check for both MIME types.
This commit is contained in:
parent
db35ffbece
commit
e375addec6
1 changed files with 4 additions and 2 deletions
|
@ -654,7 +654,7 @@ async fn load_buffers(
|
|||
load_context: &LoadContext<'_>,
|
||||
asset_path: &Path,
|
||||
) -> Result<Vec<Vec<u8>>, GltfError> {
|
||||
const OCTET_STREAM_URI: &str = "application/octet-stream";
|
||||
const VALID_MIME_TYPES: &[&str] = &["application/octet-stream", "application/gltf-buffer"];
|
||||
|
||||
let mut buffer_data = Vec::new();
|
||||
for buffer in gltf.buffers() {
|
||||
|
@ -665,7 +665,9 @@ async fn load_buffers(
|
|||
.unwrap();
|
||||
let uri = uri.as_ref();
|
||||
let buffer_bytes = match DataUri::parse(uri) {
|
||||
Ok(data_uri) if data_uri.mime_type == OCTET_STREAM_URI => data_uri.decode()?,
|
||||
Ok(data_uri) if VALID_MIME_TYPES.contains(&data_uri.mime_type) => {
|
||||
data_uri.decode()?
|
||||
}
|
||||
Ok(_) => return Err(GltfError::BufferFormatUnsupported),
|
||||
Err(()) => {
|
||||
// TODO: Remove this and add dep
|
||||
|
|
Loading…
Reference in a new issue