Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-22 04:33:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix 3D Gizmo webgpu rendering (#14653)

Browse source 
# Objective

The changes made in https://github.com/bevyengine/bevy/pull/12252
introduced an previously fixed bug in webgpu rendering.

## Solution

This fix is based on https://github.com/bevyengine/bevy/pull/8910 and
applies the same vertex buffer layout assignment for the LineGizmo
Pipeline.

## Testing

- Tested the 3D Gizmo example in webgpu and webgl environments

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This commit is contained in:
AFKessen 2024-08-09 04:55:56 +02:00 committed by GitHub
parent 297c0a3954
commit e14f3cf402
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
crates/bevy_gizmos/src/lib.rs
View file

@ -597,11 +597,16 @@ impl<P: PhaseItem> RenderCommand<P> for DrawLineGizmo {
} }
let instances = if line_gizmo.strip { let instances = if line_gizmo.strip {
pass.set_vertex_buffer(0, line_gizmo.position_buffer.slice(..)); let item_size = VertexFormat::Float32x3.size();
pass.set_vertex_buffer(1, line_gizmo.position_buffer.slice(..)); let buffer_size = line_gizmo.position_buffer.size() - item_size;
pass.set_vertex_buffer(2, line_gizmo.color_buffer.slice(..)); pass.set_vertex_buffer(0, line_gizmo.position_buffer.slice(..buffer_size));
pass.set_vertex_buffer(3, line_gizmo.color_buffer.slice(..)); pass.set_vertex_buffer(1, line_gizmo.position_buffer.slice(item_size..));
let item_size = VertexFormat::Float32x4.size();
let buffer_size = line_gizmo.color_buffer.size() - item_size;
pass.set_vertex_buffer(2, line_gizmo.color_buffer.slice(..buffer_size));
pass.set_vertex_buffer(3, line_gizmo.color_buffer.slice(item_size..));
u32::max(line_gizmo.vertex_count, 1) - 1 u32::max(line_gizmo.vertex_count, 1) - 1
} else { } else {
@ -699,13 +704,11 @@ fn line_gizmo_vertex_buffer_layouts(strip: bool) -> Vec<VertexBufferLayout> {
position_layout.clone(), position_layout.clone(),
{ {
position_layout.attributes[0].shader_location = 1; position_layout.attributes[0].shader_location = 1;
position_layout.attributes[0].offset = Float32x3.size();
position_layout position_layout
}, },
color_layout.clone(), color_layout.clone(),
{ {
color_layout.attributes[0].shader_location = 3; color_layout.attributes[0].shader_location = 3;
color_layout.attributes[0].offset = Float32x4.size();
color_layout color_layout
}, },
] ]