From c50a4d8821c16fe0ba678223b2d1fb5af73c761f Mon Sep 17 00:00:00 2001 From: JMS55 <47158642+JMS55@users.noreply.github.com> Date: Mon, 10 Jun 2024 06:00:34 -0700 Subject: [PATCH] Remove unused mip_bias parameter from apply_normal_mapping (#13752) Mip bias is no longer used here --- assets/shaders/array_texture.wgsl | 1 - crates/bevy_pbr/src/render/pbr_fragment.wgsl | 2 -- crates/bevy_pbr/src/render/pbr_functions.wgsl | 1 - crates/bevy_pbr/src/render/pbr_prepass.wgsl | 1 - 4 files changed, 5 deletions(-) diff --git a/assets/shaders/array_texture.wgsl b/assets/shaders/array_texture.wgsl index 1be9064570..d49d492a06 100644 --- a/assets/shaders/array_texture.wgsl +++ b/assets/shaders/array_texture.wgsl @@ -49,7 +49,6 @@ fn fragment( double_sided, is_front, Nt, - view.mip_bias, ); #endif diff --git a/crates/bevy_pbr/src/render/pbr_fragment.wgsl b/crates/bevy_pbr/src/render/pbr_fragment.wgsl index 7bfc4738de..2f5f4e7429 100644 --- a/crates/bevy_pbr/src/render/pbr_fragment.wgsl +++ b/crates/bevy_pbr/src/render/pbr_fragment.wgsl @@ -378,7 +378,6 @@ fn pbr_input_from_standard_material( double_sided, is_front, Nt, - view.mip_bias, ); #endif // STANDARD_MATERIAL_NORMAL_MAP @@ -408,7 +407,6 @@ fn pbr_input_from_standard_material( double_sided, is_front, clearcoat_Nt, - view.mip_bias, ); #endif // STANDARD_MATERIAL_CLEARCOAT_NORMAL_MAP diff --git a/crates/bevy_pbr/src/render/pbr_functions.wgsl b/crates/bevy_pbr/src/render/pbr_functions.wgsl index 5ba5de85b9..35e683c4ff 100644 --- a/crates/bevy_pbr/src/render/pbr_functions.wgsl +++ b/crates/bevy_pbr/src/render/pbr_functions.wgsl @@ -181,7 +181,6 @@ fn apply_normal_mapping( double_sided: bool, is_front: bool, in_Nt: vec3, - mip_bias: f32, ) -> vec3 { // Unpack the TBN vectors. var T = TBN[0]; diff --git a/crates/bevy_pbr/src/render/pbr_prepass.wgsl b/crates/bevy_pbr/src/render/pbr_prepass.wgsl index 91b6368a99..e14634b7a9 100644 --- a/crates/bevy_pbr/src/render/pbr_prepass.wgsl +++ b/crates/bevy_pbr/src/render/pbr_prepass.wgsl @@ -82,7 +82,6 @@ fn fragment( double_sided, is_front, Nt, - view.mip_bias, ); #endif // STANDARD_MATERIAL_NORMAL_MAP