mirror of
https://github.com/bevyengine/bevy
synced 2024-11-22 04:33:37 +00:00
Fix custom_loop
example to include plugin finalization (#13215)
# Objective
The `custom_loop` example didn't replicate the `app.finish` /
`app.cleanup` calls from the default runner; I discovered this when
trying to troubleshoot why my application with a custom loop wasn't
calling its plugin finalizers, and realised that the upstream example
that I'd referenced didn't have the relevant calls.
## Solution
Added the missing calls, replicating what the default runner does:
d390420093/crates/bevy_app/src/app.rs (L895-L896)
## Testing
I've confirmed that adding these two calls to my application fixed the
issue I was encountering. I haven't tested it within the example itself
as it's relatively straightforward and I didn't want to pollute the
example with a plugin using a finalizer.
This commit is contained in:
parent
c3eb3a1acf
commit
99b4fb68cc
1 changed files with 5 additions and 0 deletions
|
@ -8,6 +8,11 @@ use std::io;
|
|||
struct Input(String);
|
||||
|
||||
fn my_runner(mut app: App) -> AppExit {
|
||||
// Finalize plugin building, including running any necessary clean-up.
|
||||
// This is normally completed by the default runner.
|
||||
app.finish();
|
||||
app.cleanup();
|
||||
|
||||
println!("Type stuff into the console");
|
||||
for line in io::stdin().lines() {
|
||||
{
|
||||
|
|
Loading…
Reference in a new issue