Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2025-01-02 08:18:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

Reverted usage of NoOpHash

Browse source 
Turns out that NoOpHash works by only using the last u64 hash,
making collisions very likely when used with ArgumentSignature
This commit is contained in:
Gino Valente 2024-09-05 14:22:06 -07:00
parent 7d526ad2ba
commit 841d1bc717
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
crates/bevy_reflect/src/func/function_map.rs
View file

@ -2,7 +2,6 @@ use crate::func::signature::ArgumentSignature;
use crate::func::{ArgList, FunctionError, FunctionInfo, FunctionInfoType, FunctionOverloadError};
use alloc::borrow::Cow;
use bevy_utils::hashbrown::HashMap;
use bevy_utils::NoOpHash;
use core::ops::RangeInclusive;
/// A helper type for storing a mapping of overloaded functions
@ -28,7 +27,7 @@ pub(super) enum FunctionMap<F> {
/// A mapping of argument signatures to the index of the corresponding function.
///
/// Multiple signatures may point to the same function index (i.e. for manually created overloads).
HashMap<ArgumentSignature, usize, NoOpHash>,
HashMap<ArgumentSignature, usize>,
),
}