Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-22 12:43:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix crash when an asset load failure event is processed after asset drop (#14123)

Browse source 
# Objective

This PR fixes a crash that happens when an asset failure event is
processed after the asset has already been dropped.

```
2024-07-03T17:12:16.847178Z ERROR bevy_asset::server: Encountered HTTP status 404 when loading asset
thread 'main' panicked at bevy/crates/bevy_asset/src/server/info.rs:593:18:
```

## Solution

- Update `process_asset_fail` to match the graceful behavior in
`process_asset_load` (it does not assume the state still exists).

---

## Changelog

- Fixed a rare crash that happens when an asset failed event is
processed after the asset has been dropped.
This commit is contained in:
Brian Reavis 2024-07-07 17:58:55 -07:00 committed by GitHub
parent 900f50d77d
commit 7273ffcd78
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crates/bevy_asset/src/server/info.rs
View file

@ -588,9 +588,10 @@ impl AssetInfos {
pub(crate) fn process_asset_fail(&mut self, failed_id: UntypedAssetId, error: AssetLoadError) { pub(crate) fn process_asset_fail(&mut self, failed_id: UntypedAssetId, error: AssetLoadError) {
let (dependants_waiting_on_load, dependants_waiting_on_rec_load) = { let (dependants_waiting_on_load, dependants_waiting_on_rec_load) = {
let info = self let Some(info) = self.get_mut(failed_id) else {
.get_mut(failed_id) // The asset was already dropped.
.expect("Asset info should always exist at this point"); return;
};
info.load_state = LoadState::Failed(Box::new(error)); info.load_state = LoadState::Failed(Box::new(error));
info.dep_load_state = DependencyLoadState::Failed; info.dep_load_state = DependencyLoadState::Failed;
info.rec_dep_load_state = RecursiveDependencyLoadState::Failed; info.rec_dep_load_state = RecursiveDependencyLoadState::Failed;