Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-22 12:43:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix repeated gamepad events (#1221)

Browse source 
Previously, if the actual value of LeftStickX was e.g. 0.034 and fluctuated a little
bit (less than the threshold) it would repeatedly send out events,
because it compared the value to the *filtered* old one - 0.0 - which is
more then `0.01` (the threshold) away.

The is fixed by first doing the deadzone and then comparing to the old
value.
Another possible solution would be to store both the actual old value
and the filtered one, but that would add complexity.
This commit is contained in:
Jakob Hellermann 2021-01-07 21:35:40 +01:00 committed by GitHub
parent 9f2410a4ac
commit 599f381a6a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
crates/bevy_input/src/gamepad.rs
View file

@ -147,20 +147,22 @@ impl Default for AxisSettings {
impl AxisSettings {
fn filter(&self, new_value: f32, old_value: Option<f32>) -> Option<f32> {
let new_value = if new_value <= self.positive_low && new_value >= self.negative_low {
0.0
} else if new_value >= self.positive_high {
1.0
} else if new_value <= self.negative_high {
-1.0
} else {
new_value
};
if let Some(old_value) = old_value {
if (new_value - old_value).abs() <= self.threshold {
return None;
}
}
if new_value <= self.positive_low && new_value >= self.negative_low {
return Some(0.0);
}
if new_value >= self.positive_high {
return Some(1.0);
}
if new_value <= self.negative_high {
return Some(-1.0);
}
Some(new_value)
}
}