Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-10 07:04:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove manual apply_deferred in bevy_ui (#14768)

Browse source 
# Objective

This `apply_deferred` doesn't seem to have any effect, pointlessly
restricts parallelism and is responsible for a large number of system
order ambiguities. Spotted as part of #7386.

## Solution

Remove it.

This is the *only* manual apply_deferred in the code base currently.

## Testing

I've checked various UI examples and `split_screen`, and couldn't
discern any difference.

This looks like a remnant of a `(a, apply_deferred, b).chain()` pattern
where `b` got removed, leaving us with a weird vestige.
This commit is contained in:
Alice Cecile 2024-08-15 16:51:25 -04:00 committed by GitHub
parent b2529bf100
commit 5243fe6956
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/bevy_ui/src/lib.rs
View file

@ -166,9 +166,7 @@ impl Plugin for UiPlugin {
PostUpdate, PostUpdate,
( (
check_visibility::<WithNode>.in_set(VisibilitySystems::CheckVisibility), check_visibility::<WithNode>.in_set(VisibilitySystems::CheckVisibility),
(update_target_camera_system, apply_deferred) update_target_camera_system.in_set(UiSystem::Prepare),
.chain()
.in_set(UiSystem::Prepare),
ui_layout_system ui_layout_system
.in_set(UiSystem::Layout) .in_set(UiSystem::Layout)
.before(TransformSystem::TransformPropagate), .before(TransformSystem::TransformPropagate),

2
tests/ecs/ambiguity_detection.rs
View file

@ -33,7 +33,7 @@ fn main() {
// Over time, we are working to reduce the number: your PR should not increase it. // Over time, we are working to reduce the number: your PR should not increase it.
// If you decrease this by fixing an ambiguity, reduce the number to prevent regressions. // If you decrease this by fixing an ambiguity, reduce the number to prevent regressions.
// See https://github.com/bevyengine/bevy/issues/7386 for progress. // See https://github.com/bevyengine/bevy/issues/7386 for progress.
72, 48,
"Main app has unexpected ambiguities among the following schedules: \n{:#?}.", "Main app has unexpected ambiguities among the following schedules: \n{:#?}.",
main_app_ambiguities, main_app_ambiguities,
); );