Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-10 07:04:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix a few uninlined_format_args lints (#7368)

Browse source 
# Objective

Prevent things from breaking tomorrow when rust 1.67 is released.

## Solution

Fix a few `uninlined_format_args` lints in recently introduced code.
This commit is contained in:
Rob Parrett 2023-01-26 17:34:52 +00:00
parent 6b38863313
commit 461497fa2d
2 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
crates/bevy_pbr/src/light.rs
View file

@ -280,13 +280,11 @@ impl CascadeShadowConfig {
) -> Self {
assert!(
num_cascades > 0,
"num_cascades must be positive, but was {}",
num_cascades
"num_cascades must be positive, but was {num_cascades}",
);
assert!(
(0.0..1.0).contains(&overlap_proportion),
"overlap_proportion must be in [0.0, 1.0) but was {}",
overlap_proportion
"overlap_proportion must be in [0.0, 1.0) but was {overlap_proportion}",
);
Self {
bounds: calculate_cascade_bounds(num_cascades, nearest_bound, shadow_maximum_distance),
@ -397,8 +395,8 @@ fn calculate_cascade(
z_near: f32,
z_far: f32,
) -> Cascade {
debug_assert!(z_near <= 0.0, "z_near {} must be <= 0.0", z_near);
debug_assert!(z_far <= 0.0, "z_far {} must be <= 0.0", z_far);
debug_assert!(z_near <= 0.0, "z_near {z_near} must be <= 0.0");
debug_assert!(z_far <= 0.0, "z_far {z_far} must be <= 0.0");
// NOTE: This whole function is very sensitive to floating point precision and instability and
// has followed instructions to avoid view dependence from the section on cascade shadow maps in
// Eric Lengyel's Foundations of Game Engine Development 2: Rendering. Be very careful when

2
examples/shader/texture_binding_array.rs
View file

@ -55,7 +55,7 @@ fn setup(
let textures: Vec<_> = TILE_ID
.iter()
.map(|id| {
let path = format!("textures/rpg/tiles/generic-rpg-tile{:0>2}.png", id);
let path = format!("textures/rpg/tiles/generic-rpg-tile{id:0>2}.png");
asset_server.load(path)
})
.collect();