Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-22 04:33:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove bevy_dynamic_plugin as a default (#2578)

Browse source 
It doesn't compile on wasm, and it's full of footguns

# Objective

- If bevy is used with default features on wasm, there's more of a chance it will compile
- Note that I haven't done a full audit - it's possible that there are other problematic crates

## Solution

- `bevy_dynamic_plugin` is no longer a default plugin
- I've also done an accidental drive by reformatting of the root `Cargo.toml`, as I have [Even Better Toml](https://github.com/tamasfe/taplo) installed.
- (Please, rustfmt do this for us)
This commit is contained in:
Daniel McNab 2021-08-01 19:14:47 +00:00
parent 54ff7aaa1e
commit 43d99bb583
2 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Cargo.toml
View file

@ -22,7 +22,6 @@ members = ["crates/*", "examples/ios", "tools/ci"]
[features] [features]
default = [ default = [
"bevy_audio", "bevy_audio",
"bevy_dynamic_plugin",
"bevy_gilrs", "bevy_gilrs",
"bevy_gltf", "bevy_gltf",
"bevy_wgpu", "bevy_wgpu",
@ -38,7 +37,13 @@ default = [
dynamic = ["bevy_dylib"] dynamic = ["bevy_dylib"]
# Rendering support (Also needs the bevy_wgpu feature or a third-party rendering backend) # Rendering support (Also needs the bevy_wgpu feature or a third-party rendering backend)
render = ["bevy_internal/bevy_pbr", "bevy_internal/bevy_render", "bevy_internal/bevy_sprite", "bevy_internal/bevy_text", "bevy_internal/bevy_ui"] render = [
"bevy_internal/bevy_pbr",
"bevy_internal/bevy_render",
"bevy_internal/bevy_sprite",
"bevy_internal/bevy_text",
"bevy_internal/bevy_ui",
]
# Optional bevy crates # Optional bevy crates
bevy_audio = ["bevy_internal/bevy_audio"] bevy_audio = ["bevy_internal/bevy_audio"]
@ -82,14 +87,14 @@ subpixel_glyph_atlas = ["bevy_internal/subpixel_glyph_atlas"]
bevy_ci_testing = ["bevy_internal/bevy_ci_testing"] bevy_ci_testing = ["bevy_internal/bevy_ci_testing"]
[dependencies] [dependencies]
bevy_dylib = {path = "crates/bevy_dylib", version = "0.5.0", default-features = false, optional = true} bevy_dylib = { path = "crates/bevy_dylib", version = "0.5.0", default-features = false, optional = true }
bevy_internal = {path = "crates/bevy_internal", version = "0.5.0", default-features = false} bevy_internal = { path = "crates/bevy_internal", version = "0.5.0", default-features = false }
[dev-dependencies] [dev-dependencies]
anyhow = "1.0.4" anyhow = "1.0.4"
rand = "0.8.0" rand = "0.8.0"
ron = "0.6.2" ron = "0.6.2"
serde = {version = "1", features = ["derive"]} serde = { version = "1", features = ["derive"] }
# Needed to poll Task examples # Needed to poll Task examples
futures-lite = "1.11.3" futures-lite = "1.11.3"

2
docs/cargo_features.md
View file

@ -5,7 +5,6 @@
|feature name|description| |feature name|description|
|-|-| |-|-|
|bevy_audio|Audio support. Support for all audio formats depends on this.| |bevy_audio|Audio support. Support for all audio formats depends on this.|
|bevy_dynamic_plugin|Plugin for dynamic loading (libloading).|
|bevy_gilrs|Adds gamepad support.| |bevy_gilrs|Adds gamepad support.|
|bevy_gltf|[glTF](https://www.khronos.org/gltf/) support.| |bevy_gltf|[glTF](https://www.khronos.org/gltf/) support.|
|bevy_winit|GUI support.| |bevy_winit|GUI support.|
@ -20,6 +19,7 @@
|feature name|description| |feature name|description|
|-|-| |-|-|
|bevy_dynamic_plugin|Plugin for dynamic loading (using [libloading](https://crates.io/crates/libloading)).|
|dynamic|Forces bevy to be dynamically linked, which improves iterative compile times.| |dynamic|Forces bevy to be dynamically linked, which improves iterative compile times.|
|trace|Enables system tracing (useful in tandem with a feature like trace_chrome).| |trace|Enables system tracing (useful in tandem with a feature like trace_chrome).|
|trace_chrome|Enables [tracing-chrome](https://github.com/thoren-d/tracing-chrome) as bevy_log output. This allows you to visualize system execution.| |trace_chrome|Enables [tracing-chrome](https://github.com/thoren-d/tracing-chrome) as bevy_log output. This allows you to visualize system execution.|