Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2025-02-16 14:08:32 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use batch spawn in benchmarks (#11611)

Browse source 
# Objective

- The benchmarks for `bevy_ecs`' `iter_simple` group use `for` loops
instead of `World::spawn_batch`.
- There's a TODO comment that says to batch spawn them.

## Solution

- Replace the `for` loops with `World::spawn_batch`.
This commit is contained in:
BD103 2024-02-01 14:23:09 -05:00 • committed by GitHub
parent e3cf5f8fb2
commit 3d2d61d063
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 45 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
benches/benches/bevy_ecs/iteration/iter_simple.rs
View file

@ -19,15 +19,15 @@ impl<'w> Benchmark<'w> {
pub fn new() -> Self { pub fn new() -> Self {
let mut world = World::new(); let mut world = World::new();
// TODO: batch this world.spawn_batch(
for _ in 0..10_000 { std::iter::repeat((
world.spawn((
Transform(Mat4::from_scale(Vec3::ONE)), Transform(Mat4::from_scale(Vec3::ONE)),
Position(Vec3::X), Position(Vec3::X),
Rotation(Vec3::X), Rotation(Vec3::X),
Velocity(Vec3::X), Velocity(Vec3::X),
)); ))
} .take(10_000),
);
let query = world.query::<(&Velocity, &mut Position)>(); let query = world.query::<(&Velocity, &mut Position)>();
Self(world, query) Self(world, query)

10
benches/benches/bevy_ecs/iteration/iter_simple_foreach.rs
View file

@ -19,15 +19,15 @@ impl<'w> Benchmark<'w> {
pub fn new() -> Self { pub fn new() -> Self {
let mut world = World::new(); let mut world = World::new();
// TODO: batch this world.spawn_batch(
for _ in 0..10_000 { std::iter::repeat((
world.spawn((
Transform(Mat4::from_scale(Vec3::ONE)), Transform(Mat4::from_scale(Vec3::ONE)),
Position(Vec3::X), Position(Vec3::X),
Rotation(Vec3::X), Rotation(Vec3::X),
Velocity(Vec3::X), Velocity(Vec3::X),
)); ))
} .take(10_000),
);
let query = world.query::<(&Velocity, &mut Position)>(); let query = world.query::<(&Velocity, &mut Position)>();
Self(world, query) Self(world, query)

10
benches/benches/bevy_ecs/iteration/iter_simple_foreach_sparse_set.rs
View file

@ -21,15 +21,15 @@ impl<'w> Benchmark<'w> {
pub fn new() -> Self { pub fn new() -> Self {
let mut world = World::new(); let mut world = World::new();
// TODO: batch this world.spawn_batch(
for _ in 0..10_000 { std::iter::repeat((
world.spawn((
Transform(Mat4::from_scale(Vec3::ONE)), Transform(Mat4::from_scale(Vec3::ONE)),
Position(Vec3::X), Position(Vec3::X),
Rotation(Vec3::X), Rotation(Vec3::X),
Velocity(Vec3::X), Velocity(Vec3::X),
)); ))
} .take(10_000),
);
let query = world.query::<(&Velocity, &mut Position)>(); let query = world.query::<(&Velocity, &mut Position)>();
Self(world, query) Self(world, query)

10
benches/benches/bevy_ecs/iteration/iter_simple_foreach_wide.rs
View file

@ -33,9 +33,8 @@ impl<'w> Benchmark<'w> {
pub fn new() -> Self { pub fn new() -> Self {
let mut world = World::new(); let mut world = World::new();
// TODO: batch this world.spawn_batch(
for _ in 0..10_000 { std::iter::repeat((
world.spawn((
Transform(Mat4::from_scale(Vec3::ONE)), Transform(Mat4::from_scale(Vec3::ONE)),
Rotation(Vec3::X), Rotation(Vec3::X),
Position::<0>(Vec3::X), Position::<0>(Vec3::X),
@ -48,8 +47,9 @@ impl<'w> Benchmark<'w> {
Velocity::<3>(Vec3::X), Velocity::<3>(Vec3::X),
Position::<4>(Vec3::X), Position::<4>(Vec3::X),
Velocity::<4>(Vec3::X), Velocity::<4>(Vec3::X),
)); ))
} .take(10_000),
);
let query = world.query(); let query = world.query();
Self(world, query) Self(world, query)

10
benches/benches/bevy_ecs/iteration/iter_simple_foreach_wide_sparse_set.rs
View file

@ -35,9 +35,8 @@ impl<'w> Benchmark<'w> {
pub fn new() -> Self { pub fn new() -> Self {
let mut world = World::new(); let mut world = World::new();
// TODO: batch this world.spawn_batch(
for _ in 0..10_000 { std::iter::repeat((
world.spawn((
Transform(Mat4::from_scale(Vec3::ONE)), Transform(Mat4::from_scale(Vec3::ONE)),
Rotation(Vec3::X), Rotation(Vec3::X),
Position::<0>(Vec3::X), Position::<0>(Vec3::X),
@ -50,8 +49,9 @@ impl<'w> Benchmark<'w> {
Velocity::<3>(Vec3::X), Velocity::<3>(Vec3::X),
Position::<4>(Vec3::X), Position::<4>(Vec3::X),
Velocity::<4>(Vec3::X), Velocity::<4>(Vec3::X),
)); ))
} .take(10_000),
);
let query = world.query(); let query = world.query();
Self(world, query) Self(world, query)

10
benches/benches/bevy_ecs/iteration/iter_simple_sparse_set.rs
View file

@ -21,15 +21,15 @@ impl<'w> Benchmark<'w> {
pub fn new() -> Self { pub fn new() -> Self {
let mut world = World::new(); let mut world = World::new();
// TODO: batch this world.spawn_batch(
for _ in 0..10_000 { std::iter::repeat((
world.spawn((
Transform(Mat4::from_scale(Vec3::ONE)), Transform(Mat4::from_scale(Vec3::ONE)),
Position(Vec3::X), Position(Vec3::X),
Rotation(Vec3::X), Rotation(Vec3::X),
Velocity(Vec3::X), Velocity(Vec3::X),
)); ))
} .take(10_000),
);
let query = world.query::<(&Velocity, &mut Position)>(); let query = world.query::<(&Velocity, &mut Position)>();
Self(world, query) Self(world, query)

10
benches/benches/bevy_ecs/iteration/iter_simple_system.rs
View file

@ -19,15 +19,15 @@ impl Benchmark {
pub fn new() -> Self { pub fn new() -> Self {
let mut world = World::new(); let mut world = World::new();
// TODO: batch this world.spawn_batch(
for _ in 0..10_000 { std::iter::repeat((
world.spawn((
Transform(Mat4::from_scale(Vec3::ONE)), Transform(Mat4::from_scale(Vec3::ONE)),
Position(Vec3::X), Position(Vec3::X),
Rotation(Vec3::X), Rotation(Vec3::X),
Velocity(Vec3::X), Velocity(Vec3::X),
)); ))
} .take(10_000),
);
fn query_system(mut query: Query<(&Velocity, &mut Position)>) { fn query_system(mut query: Query<(&Velocity, &mut Position)>) {
for (velocity, mut position) in &mut query { for (velocity, mut position) in &mut query {

10
benches/benches/bevy_ecs/iteration/iter_simple_wide.rs
View file

@ -33,9 +33,8 @@ impl<'w> Benchmark<'w> {
pub fn new() -> Self { pub fn new() -> Self {
let mut world = World::new(); let mut world = World::new();
// TODO: batch this world.spawn_batch(
for _ in 0..10_000 { std::iter::repeat((
world.spawn((
Transform(Mat4::from_scale(Vec3::ONE)), Transform(Mat4::from_scale(Vec3::ONE)),
Rotation(Vec3::X), Rotation(Vec3::X),
Position::<0>(Vec3::X), Position::<0>(Vec3::X),
@ -48,8 +47,9 @@ impl<'w> Benchmark<'w> {
Velocity::<3>(Vec3::X), Velocity::<3>(Vec3::X),
Position::<4>(Vec3::X), Position::<4>(Vec3::X),
Velocity::<4>(Vec3::X), Velocity::<4>(Vec3::X),
)); ))
} .take(10_000),
);
let query = world.query(); let query = world.query();
Self(world, query) Self(world, query)

10
benches/benches/bevy_ecs/iteration/iter_simple_wide_sparse_set.rs
View file

@ -35,9 +35,8 @@ impl<'w> Benchmark<'w> {
pub fn new() -> Self { pub fn new() -> Self {
let mut world = World::new(); let mut world = World::new();
// TODO: batch this world.spawn_batch(
for _ in 0..10_000 { std::iter::repeat((
world.spawn((
Transform(Mat4::from_scale(Vec3::ONE)), Transform(Mat4::from_scale(Vec3::ONE)),
Rotation(Vec3::X), Rotation(Vec3::X),
Position::<0>(Vec3::X), Position::<0>(Vec3::X),
@ -50,8 +49,9 @@ impl<'w> Benchmark<'w> {
Velocity::<3>(Vec3::X), Velocity::<3>(Vec3::X),
Position::<4>(Vec3::X), Position::<4>(Vec3::X),
Velocity::<4>(Vec3::X), Velocity::<4>(Vec3::X),
)); ))
} .take(10_000),
);
let query = world.query(); let query = world.query();
Self(world, query) Self(world, query)