Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-22 12:43:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove wasm audio feature flag for 2021 (#3000)

Browse source 
- Requires #2997 
- Removes `wasm_audio` feature as discussed in #2397
- Closes only task in #2479 

Open questions:
Should we enable wasm audio by default or only when building for wasm using `cfg`?
Maybe there should be a global wasm feature for bevy?
This commit is contained in:
Ixentus 2021-11-11 01:17:38 +00:00
parent 12e0b80cd0
commit 36394adb2f
4 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Cargo.toml
View file

@ -68,9 +68,6 @@ mp3 = ["bevy_internal/mp3"]
vorbis = ["bevy_internal/vorbis"] vorbis = ["bevy_internal/vorbis"]
wav = ["bevy_internal/wav"] wav = ["bevy_internal/wav"]
# WASM support for audio (Currently only works with flac, wav and vorbis. Not with mp3)
wasm_audio = ["bevy_internal/wasm_audio"]
serialize = ["bevy_internal/serialize"] serialize = ["bevy_internal/serialize"]
# Display server protocol support (X11 is enabled by default) # Display server protocol support (X11 is enabled by default)

4
crates/bevy_audio/Cargo.toml
View file

@ -21,9 +21,11 @@ anyhow = "1.0.4"
rodio = { version = "0.14", default-features = false } rodio = { version = "0.14", default-features = false }
parking_lot = "0.11.0" parking_lot = "0.11.0"
[target.'cfg(target_arch = "wasm32")'.dependencies]
rodio = { version = "0.14", default-features = false, features = ["wasm-bindgen"] }
[features] [features]
mp3 = ["rodio/mp3"] mp3 = ["rodio/mp3"]
flac = ["rodio/flac"] flac = ["rodio/flac"]
wav = ["rodio/wav"] wav = ["rodio/wav"]
vorbis = ["rodio/vorbis"] vorbis = ["rodio/vorbis"]
wasm_audio = ["rodio/wasm-bindgen"]

3
crates/bevy_internal/Cargo.toml
View file

@ -29,9 +29,6 @@ mp3 = ["bevy_audio/mp3"]
vorbis = ["bevy_audio/vorbis"] vorbis = ["bevy_audio/vorbis"]
wav = ["bevy_audio/wav"] wav = ["bevy_audio/wav"]
# WASM support for audio
wasm_audio = ["bevy_audio/wasm_audio"]
serialize = ["bevy_input/serialize"] serialize = ["bevy_input/serialize"]
# Display server protocol support (X11 is enabled by default) # Display server protocol support (X11 is enabled by default)

1
docs/cargo_features.md
View file

@ -32,7 +32,6 @@
|flac|FLAC audio format support. It's included in bevy_audio feature.| |flac|FLAC audio format support. It's included in bevy_audio feature.|
|wav|WAV audio format support.| |wav|WAV audio format support.|
|vorbis|Vorbis audio format support.| |vorbis|Vorbis audio format support.|
|wasm_audio|WASM audio support. (Currently only works with flac, wav and vorbis. Not with mp3)|
|serialize|Enables serialization of `bevy_input` types.| |serialize|Enables serialization of `bevy_input` types.|
|wayland|Enable this to use Wayland display server protocol other than X11.| |wayland|Enable this to use Wayland display server protocol other than X11.|
|subpixel_glyph_atlas|Enable this to cache glyphs using subpixel accuracy. This increases texture memory usage as each position requires a separate sprite in the glyph atlas, but provide more accurate character spacing.| |subpixel_glyph_atlas|Enable this to cache glyphs using subpixel accuracy. This increases texture memory usage as each position requires a separate sprite in the glyph atlas, but provide more accurate character spacing.|