From 1d7f66347571712b516bd33bd27e5097533e23aa Mon Sep 17 00:00:00 2001 From: Benjamin Brienen Date: Mon, 11 Nov 2024 19:47:51 +0100 Subject: [PATCH] Clean up some yaml mistakes (#16300) # Objective Our build pipeline should have no grammar or syntax mistakes. ## Solution Remove a reference to a non-existent variable and clean up the taplo `echo`s. --- .github/workflows/ci.yml | 6 +++--- .github/workflows/validation-jobs.yml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0d804d0f05..bb3fb5770b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -230,10 +230,10 @@ jobs: - name: Taplo info if: failure() run: | - echo 'To fix toml fmt, please run `taplo fmt`' - echo 'To check for a diff, run `taplo fmt --check --diff' + echo 'To fix toml fmt, please run `taplo fmt`.' + echo 'To check for a diff, run `taplo fmt --check --diff`.' echo 'You can find taplo here: https://taplo.tamasfe.dev/' - echo 'Or if you use VSCode, use the `Even Better Toml` extension with 2 spaces' + echo 'Or if you use VSCode, use the `Even Better Toml` extension.' echo 'You can find the extension here: https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml' typos: diff --git a/.github/workflows/validation-jobs.yml b/.github/workflows/validation-jobs.yml index 424177e37d..749adf196c 100644 --- a/.github/workflows/validation-jobs.yml +++ b/.github/workflows/validation-jobs.yml @@ -31,7 +31,7 @@ jobs: with: path: | target - key: ${{ runner.os }}-ios-install-${{ matrix.toolchain }}-${{ hashFiles('**/Cargo.lock') }} + key: ${{ runner.os }}-ios-install-${{ hashFiles('**/Cargo.lock') }} # TODO: remove x86 target once it always run on arm GitHub runners - name: Add iOS targets