From 1a18ab34c41a4822bf8f673106cb0ec4b9edd327 Mon Sep 17 00:00:00 2001 From: MinerSebas Date: Thu, 2 Feb 2023 15:09:06 +0000 Subject: [PATCH] Remove unnecessary `Default` impl of HandleType (#7472) # Objective - Resolve a Fixme to remove the `Default` impl for `HandleType`, once Reflection no longer requires it. - Presumebly this Comment was made before the `FromReflect` Derive used the `#[reflect(Default)]`, to substitute for the requirment that a ignored field has a `Default`. ## Solution - Just remove the `Default` derive and comment. --- crates/bevy_asset/src/handle.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/crates/bevy_asset/src/handle.rs b/crates/bevy_asset/src/handle.rs index dfa4bd2d35..d37eebca71 100644 --- a/crates/bevy_asset/src/handle.rs +++ b/crates/bevy_asset/src/handle.rs @@ -116,10 +116,7 @@ where marker: PhantomData T>, } -// FIXME: Default is only needed because `Handle`'s field `handle_type` is currently ignored for reflection -#[derive(Default)] enum HandleType { - #[default] Weak, Strong(Sender), }