Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-22 12:43:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

Drain ExtractedUiNodes in prepare_uinodes (#9142)

Browse source 
# Objective

`ExtractedUiNodes` is cleared by the `extract_uinodes` function during
the extraction schedule. Because the Bevy UI renderer uses a painters
algorithm, this makes it impossible for users to create a custom
extraction function that adds items for a node to be drawn behind the
rectangle added by `extract_uniodes`.

## Solution

Drain `ExtractedUiNodes` in `prepare_ui_nodes` instead, after the
extraction schedule has finished.
This commit is contained in:
ickshonpe 2023-07-14 00:35:22 +01:00 committed by GitHub
parent c720e7fb5e
commit 0df3d7f586
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/bevy_ui/src/render/mod.rs
View file

@ -391,8 +391,6 @@ pub fn extract_uinodes(
>,
>,
) {
extracted_uinodes.uinodes.clear();
for (stack_index, entity) in ui_stack.uinodes.iter().enumerate() {
if let Ok((uinode, transform, color, maybe_image, visibility, clip)) =
uinode_query.get(*entity)
@ -636,7 +634,7 @@ pub fn prepare_uinodes(
image.id() != DEFAULT_IMAGE_HANDLE.id()
}
for extracted_uinode in &extracted_uinodes.uinodes {
for extracted_uinode in extracted_uinodes.uinodes.drain(..) {
let mode = if is_textured(&extracted_uinode.image) {
if current_batch_image.id() != extracted_uinode.image.id() {
if is_textured(&current_batch_image) && start != end {