Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-22 12:43:34 +00:00
Code Issues Projects Releases Packages Wiki Activity
bevy/tools/example-showcase/window-settings-wasm.patch

17 lines
651 B
Diff
Raw Normal View History

examples showcase: use patches instead of sed for wasm hacks (#10601) # Objective - Fix the asset hack for wasm examples so that they work on the website - Use patches instead of sed for wasm hacks so that it fails explicitly when they need to be updated
2023-11-17 22:21:12 +00:00
diff --git a/crates/bevy_window/src/window.rs b/crates/bevy_window/src/window.rs
Fix example showcase wasm window settings patch (#12608) # Objective FIx this failed workflow: <https://github.com/bevyengine/bevy/actions/runs/8367408952/job/22909715870#step:7:11> ## Solution Make the required changes on fresh Bevy code and save a new patch
2024-04-06 22:07:49 +00:00
index ccc861a78..0cae580cd 100644
examples showcase: use patches instead of sed for wasm hacks (#10601) # Objective - Fix the asset hack for wasm examples so that they work on the website - Use patches instead of sed for wasm hacks so that it fails explicitly when they need to be updated
2023-11-17 22:21:12 +00:00
--- a/crates/bevy_window/src/window.rs
+++ b/crates/bevy_window/src/window.rs
Fix example showcase wasm window settings patch (#12608) # Objective FIx this failed workflow: <https://github.com/bevyengine/bevy/actions/runs/8367408952/job/22909715870#step:7:11> ## Solution Make the required changes on fresh Bevy code and save a new patch
2024-04-06 22:07:49 +00:00
@@ -293,9 +293,9 @@ impl Default for Window {
examples showcase: use patches instead of sed for wasm hacks (#10601) # Objective - Fix the asset hack for wasm examples so that they work on the website - Use patches instead of sed for wasm hacks so that it fails explicitly when they need to be updated
2023-11-17 22:21:12 +00:00
transparent: false,
focused: true,
window_level: Default::default(),
Fix fit_canvas_to_parent (#11278) Follow up to #11057 Implemented suggestions from reviewers from: a simpler fit_canvas_to_parent leads to an explicit CSS setting to the canvas. From my understanding, it has do be set after wgpu creation due to wgpu overriding the canvas width/height: https://github.com/gfx-rs/wgpu/blob/4400a5847080d1164bdca93a90622414963ed9f3/examples/src/utils.rs#L68-L74 # Changelog - Re-enable a `fit_canvas_to_parent`, it's removal from https://github.com/bevyengine/bevy/pull/11057 was problematic. Still, its inner working is more simple than before: bevy doesn't handle its resizing, winit does. ## Migration Guide - Cancels the migration from https://github.com/bevyengine/bevy/pull/11057
2024-03-03 14:33:30 +00:00
- fit_canvas_to_parent: false,
+ fit_canvas_to_parent: true,
examples showcase: use patches instead of sed for wasm hacks (#10601) # Objective - Fix the asset hack for wasm examples so that they work on the website - Use patches instead of sed for wasm hacks so that it fails explicitly when they need to be updated
2023-11-17 22:21:12 +00:00
prevent_default_event_handling: true,
- canvas: None,
+ canvas: Some("#bevy".to_string()),
window_theme: None,
visible: true,
Fix example showcase wasm window settings patch (#12608) # Objective FIx this failed workflow: <https://github.com/bevyengine/bevy/actions/runs/8367408952/job/22909715870#step:7:11> ## Solution Make the required changes on fresh Bevy code and save a new patch
2024-04-06 22:07:49 +00:00
skip_taskbar: false,
Reference in a new issue Copy permalink