From df5793a41c3ca04204df749b1a15ef0b476383b4 Mon Sep 17 00:00:00 2001 From: Anarion Date: Thu, 7 Mar 2024 09:40:14 +0100 Subject: [PATCH] Address most of review comments --- README.md | 2 +- roles/valheim/defaults/main.yml | 3 +-- roles/valheim/molecule/default/verify_stopped.yml | 2 +- roles/valheim/tasks/main.yml | 6 +++--- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 5175202a..7705da96 100644 --- a/README.md +++ b/README.md @@ -106,8 +106,8 @@ If you have a spare domain name you can configure applications to be accessible * [Transmission](https://transmissionbt.com/) - BitTorrent client (with OpenVPN if you have a supported VPN provider) * [Ubooquity](http://vaemendis.net/ubooquity/) - Book and comic server * [uTorrent](https://www.utorrent.com/) - The best torrent downloading app for beginners -* [Virtual Desktop](https://github.com/RattyDAVE/docker-ubuntu-xrdp-mate-custom) - A virtual desktop running on your NAS. * [Valheim Server](https://github.com/mbround18/valheim-docker) - Valheim dedicated gameserver manager. +* [Virtual Desktop](https://github.com/RattyDAVE/docker-ubuntu-xrdp-mate-custom) - A virtual desktop running on your NAS. * [Wallabag](https://wallabag.org/) - Save and classify articles. Read them later. * [Watchtower](https://github.com/v2tec/watchtower) - Monitor your Docker containers and update them if a new version is available * [Wireshark](https://www.wireshark.org/) - the world’s foremost and widely-used network protocol analyzer. diff --git a/roles/valheim/defaults/main.yml b/roles/valheim/defaults/main.yml index 39d70a8f..cb18793a 100644 --- a/roles/valheim/defaults/main.yml +++ b/roles/valheim/defaults/main.yml @@ -3,8 +3,7 @@ valheim_enabled: false valheim_available_externally: false # directories -valheim_home: "{{ docker_home }}/valheim" -valheim_data_directory: "{{ valheim_home }}/valheim" +valheim_data_directory: "{{ docker_home }}/valheim" # network valheim_port_a: "2456" diff --git a/roles/valheim/molecule/default/verify_stopped.yml b/roles/valheim/molecule/default/verify_stopped.yml index ea0d8632..d91481d3 100644 --- a/roles/valheim/molecule/default/verify_stopped.yml +++ b/roles/valheim/molecule/default/verify_stopped.yml @@ -12,7 +12,7 @@ state: absent register: result - - name: Check if joomla is stopped + - name: Check if Valheim is stopped ansible.builtin.assert: that: - not result.changed diff --git a/roles/valheim/tasks/main.yml b/roles/valheim/tasks/main.yml index 00c18ce1..4f3dd6ec 100644 --- a/roles/valheim/tasks/main.yml +++ b/roles/valheim/tasks/main.yml @@ -64,9 +64,9 @@ labels: traefik.enable: "{{ valheim_available_externally | string }}" traefik.http.routers.valheim.rule: "Host(`{{ valheim_hostname }}.{{ ansible_nas_domain }}`)" - # traefik.http.routers.valheim.tls.certresolver: "letsencrypt" - # traefik.http.routers.valheim.tls.domains[0].main: "{{ ansible_nas_domain }}" - # traefik.http.routers.valheim.tls.domains[0].sans: "*.{{ ansible_nas_domain }}" + traefik.http.routers.valheim.tls.certresolver: "letsencrypt" + traefik.http.routers.valheim.tls.domains[0].main: "{{ ansible_nas_domain }}" + traefik.http.routers.valheim.tls.domains[0].sans: "*.{{ ansible_nas_domain }}" traefik.http.services.valheim.loadbalancer.server.port: "2456" when: valheim_enabled is true