Merge pull request #83 from scotws/vagrant

Notes required Vagrant version, closes #74
This commit is contained in:
David Stephens 2019-04-15 18:21:21 +01:00 committed by GitHub
commit 12acf13d2a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -118,8 +118,13 @@ Getting help is easy! You can:
Contributions are welcome, please feel free to raise a PR! Contributions are welcome, please feel free to raise a PR!
* Restrict pull requests to one piece of functionality or bugfix at a time. * Restrict pull requests to one piece of functionality or bugfix at a time.
* Test your new functionality or bugfix using the included `tests/test-vagrant.sh` script to spin up a test VM. * Test your new functionality or bugfix using the included
* Run `ansible-lint` against the playbook before committing. (There is a VSCode task set up to run the right command for you) `tests/test-vagrant.sh` script to spin up a test VM. Note that Ansible-NAS
requires Vagrant version 2.2.2 or later, so for stock Ubuntu 18.04.2, you will
have to download and install the newest version from
https://www.vagrantup.com/downloads.html .
* Run `ansible-lint` against the playbook before committing. (There is a VSCode
task set up to run the right command for you)
* Please know that your efforts are appreciated, thanks! :+1: * Please know that your efforts are appreciated, thanks! :+1:
Development of Ansible-NAS is carried out in [Visual Studio Code](https://code.visualstudio.com/) - you'll get some nice Development of Ansible-NAS is carried out in [Visual Studio Code](https://code.visualstudio.com/) - you'll get some nice