Commit graph

59 commits

Author SHA1 Message Date
gardar
083ff4ef36
skip_changelog: make testinfra tests capture logs on service failure
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-08-18 15:47:32 +00:00
francisco-core
82adcbafb2 Fix 404 TLS auth links
Signed-off-by: francisco-core <32313429+francisco-core@users.noreply.github.com>
2023-08-16 12:19:24 +00:00
github-actions[bot]
ef105aa4f9
patch: 🎉 automated upstream release update (#162)
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Co-authored-by: prombot <prometheus-team@googlegroups.com>
2023-07-23 10:33:34 +02:00
prombot
7a39a41196 patch: 🎉 automated upstream release update
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2023-06-01 14:27:50 +00:00
Jonathan Mabit
7047669da7 fix: Install package fact dependencies needs to be run as root
Signed-off-by: Jonathan Mabit <jonathan.mabit@dametis.com>
2023-05-25 13:43:24 +02:00
Logan Pulley
456d8ac946
fix: always create config file
Signed-off-by: Logan Pulley <logan@pulley.host>
2023-05-21 15:12:35 -05:00
Anton Lugovoi
fddefacd39
issue 92: remove recurse for textfile collector dir because it causes consistent ansible changes in case there are new metric files created by other users
Signed-off-by: Anton Lugovoi <alugovoi@ordercapital.com>
2023-05-16 14:17:52 +00:00
Kevin Bowrin
be0a877b00
node_exporter: Fix Systemd ProtectHome option in service unit
Fixes an issue with the jinja2 snippet which is used to create the node_exporter Systemd unit. More details here: https://github.com/prometheus-community/ansible/issues/13

Jinja2 namespaces are used to ensure the variable `protect_home` can be set in the parent scope of the `for` loop looking through the mounts.

Signed-off-by: Kevin Bowrin <kevinbowrin@cunet.carleton.ca>
2023-05-09 16:13:50 -04:00
gardar
927ec4ede4
Merge pull request #87 from laurent-indermuehle/lie_add_tags_support_for_included_tasks
fix: tags support for included tasks
2023-05-03 12:03:55 +00:00
Laurent Indermuehle
f0973a0dbc
Add apply tags for all included tasks files
Signed-off-by: Laurent Indermuehle <laurent.indermuehle@epfl.ch>
2023-04-27 09:36:20 +02:00
gardar
9e64a645db
fix: document supported platform versions
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-04-26 18:23:29 +00:00
gardar
d53f2cbd03
fix: supported platforms in beta
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-04-26 17:20:32 +00:00
gardar
6231861c44
fix: pass token to github api for higher ratelimit
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-04-26 15:40:32 +00:00
Ilari Iso-Junno
9812360144 enhancement: support ansible-vaulted basic auth passwords
If ansible-vaulted password is passed to password_hash filter, it will throw and error:
'secret must be unicode or bytes, not ansible.parsing.yaml.objects.AnsibleVaultEncryptedUnicode'
Handling the vaulted password with string filter first will avoid the problem.

Signed-off-by: Ilari Iso-Junno <iisojunn@users.noreply.github.com>
2023-04-12 10:45:46 +03:00
gardar
2a1123ad94
docs: avoid maintaining variable documentation in many places
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-04-11 14:48:13 +00:00
Christian Brabandt
c1a80960f6
enhancement(node_exporter): add skip_install variable
This is similar to prometheus_skip_install variable and does what the
name says: when set, it won't try to re-download the node exporter
binary

Signed-off-by: Christian Brabandt <cb@256bit.org>
2023-03-21 15:54:17 +01:00
gardar
4bd1d504a3
Merge pull request #71 from alkinks/node_exporter_systemd_template_fix
fix: correct quotation of flags in systemd config file
2023-03-21 10:41:11 +00:00
Ben Kochie
bf538d2088
Merge pull request #43 from andygrunwald/node-exporter-mark-latest-as-value
docs: Quote value latest to be explicit about the possible value for node_exporter_version
2023-03-21 09:43:37 +01:00
Andrew Kingston
7437ac0a64 fix: correct quotation of flags in systemd config file
Correct the quotation around the collector option flags and values
in the node_exporter role systemd unit config file template so that
regex values get parsed correctly.

Refs: #68
Signed-off-by: Andrew Kingston <andrew.kingston@framestore.com>
2023-03-20 12:27:42 +00:00
Andrew Kingston
a2fa58b772 fix: remove quotation of flags in systemd config file
Remove the quotation around the collector option flags and values
in the node_exporter role systemd unit config file template so that
regex values get parsed correctly.

Refs: #68
Signed-off-by: Andrew Kingston <andrew.kingston@framestore.com>
2023-03-20 12:27:42 +00:00
Andrew Kingston
ebae6c7610 fix: correct quotation of flags in systemd config file
Correct the quotation around the collector option flags and values
in the node_exporter role systemd unit config file template so that
regex values get parsed correctly.

Refs: #68
Signed-off-by: Andrew Kingston <andrew.kingston@framestore.com>
2023-03-20 12:27:42 +00:00
prombot
7522f150ae
Fixup version bumper job
Move role repo discovery to a script to avoid shell escaping issues.
* Fix up argument_specs.yml.

Signed-off-by: prombot <prometheus-team@googlegroups.com>
2023-03-14 07:19:57 +01:00
gardar
837e9404d7
Merge pull request #63 from mikaellanger/fix-policycoreutils-python
fix: policycoreutils python package name
2023-03-13 18:21:39 +00:00
Ben Kochie
4f027625b3
Merge pull request #65 from gardar/fix-var-style
refactor: underscore variable prefix should be reserved...
2023-03-13 13:39:26 +01:00
Ben Kochie
a09941b753
skip-release: Add workflow to auto-update versions (#48)
Add a script and workflow to automatically check for upstream releases
and create PRs to update the associated role.

Signed-off-by: SuperQ <superq@gmail.com>
2023-03-11 16:35:19 +01:00
gardar
585ac79c46
refactor: underscore prefix should be reserved for nonconfigurable internal variables
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-03-09 17:56:31 +00:00
mikaellanger
315474451d
Fix policycoreutils python package name
Signed-off-by: mikaellanger <mikael.langer@gmail.com>
2023-03-09 12:45:20 +01:00
gardar
6fa5e0528a
fix: install package_facts dependencies
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-03-08 18:03:00 +00:00
gardar
e02e6a5976
refactor: avoid using command module for systemd version fact
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-03-08 18:03:00 +00:00
gardar
f919f53abf
Merge pull request #58 from prometheus-community/superq/arg_newlines
refactor: Disable line-length check in arguments_specs
2023-03-08 13:03:39 +00:00
Valentin Delaye
eb5812315b
fix: Fix typo on Install selinux python packages for RedHat family (#57)
Signed-off-by: Valentin Delaye <jonesbusy@gmail.com>
2023-03-08 11:43:46 +01:00
prombot
861747162a
Disable line-length check in arguments_specs
Allow long lines in the arguments_spec to avoid line wrapping. This
allows the files to be processed with `yq` without constant diffs and
errors.

Signed-off-by: prombot <prometheus-team@googlegroups.com>
2023-03-08 08:15:06 +01:00
gardar
081f7797a7
fix: add binary/checksum urls to argument specs
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-03-06 22:18:35 +00:00
Andy Grunwald
7bc4f474e3
docs: Remove references to to previous named ansible collection cloudalchemy
The repository is a migration from https://github.com/cloudalchemy/ansible-node-exporter.
The previous repository has been marked as archived already.

Signed-off-by: Andy Grunwald <andygrunwald@gmail.com>
2023-03-06 09:59:42 +01:00
Andy Grunwald
92cb8461a7
docs: Quote value latest to be explicit about the possible value for node_exporter_version
In the docs, the value "latest" was written as a normal string.
By quoting it via `, it marks it explicit as a possible value to accept for node_exporter_version.
Otherwise, it is easy overlooked as acceptable value.

Signed-off-by: Andy Grunwald <andygrunwald@gmail.com>
2023-03-05 11:13:47 +01:00
gardar
3874d05931
docs: add node_exporter argument specs
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-03-05 09:51:57 +00:00
gardar
12a8260b2b
refactor: support customizing node_exporter url/mirror
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-03-02 12:49:34 +00:00
gardar
4eace3831e
fix: avoid hitting api rate limit in lookups
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-01-14 01:00:49 +00:00
gardar
3227cf01ec
fix: future-import-boilerplate and metaclass-boilerplate
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-01-11 19:50:51 +00:00
gardar
59eb8438fa
fix: role test requirements
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-01-11 19:45:10 +00:00
gardar
364d06f294
refactor: combine molecule config
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-01-11 19:37:31 +00:00
gardar
92f54b4ae7
fix: remove unneeded prepare playbooks
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-01-11 19:30:37 +00:00
gardar
3c9df6fae7
fix: use fcqn for role names
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-01-11 19:27:47 +00:00
gardar
4efb8fe813
fix: use default playbook for converge
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-01-11 19:17:30 +00:00
gardar
310c1e68cf
style: fix lint
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-01-11 19:05:01 +00:00
gardar
1b3f19e2be
fix: avoid spaces when doing line breaks on long urls
Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-01-11 18:58:59 +00:00
Ben Kochie
1e41dec0dc
Merge pull request #10 from cudevmaxwell/issue-9
node_exporter: Change command parameters for ansible 2.14 compatibility
2022-12-24 20:34:23 +01:00
Ben Kochie
bed08e8a45
Merge pull request #12 from cudevmaxwell/issue-11
node_exporter: Fix broken config file CLI flag name
2022-12-24 18:47:28 +01:00
Kevin Bowrin
5d47937e3b
node_exporter: Support filesystems mounted under '/home'
Set systemd's ProtectHome to 'read-only' instead of
'yes' if there exists filesystems which are mounted
at or under '/home', instead of at '/home' exclusively.

Fixes #13.

Signed-off-by: Kevin Bowrin <kevinbowrin@cunet.carleton.ca>
2022-12-23 16:08:26 -05:00
Kevin Bowrin
ec6c857129
Remove warn for Ansible 2.14 compatibility
Remove unnecessary warn parameter. Fixes #9.

Signed-off-by: Kevin Bowrin <kevinbowrin@cunet.carleton.ca>
2022-12-23 15:08:57 -05:00