Mirrors/Tone.js
2
0
Fork 0
mirror of https://github.com/Tonejs/Tone.js synced 2024-11-15 16:17:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

make sure the right voice is released by flagging a voice as released

Browse source
This commit is contained in:
Yotam Mann 2019-10-16 14:31:40 -04:00
parent d1e259238f
commit bc0d83d4cf
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Tone/instrument/PolySynth.ts
View file

@ -66,7 +66,7 @@ export class PolySynth<Voice extends Monophonic<any> = Synth> extends Instrument
/**
* The currently active voices
*/
private _activeVoices: Array<{midi: MidiNote; voice: Voice}> = [];
private _activeVoices: Array<{midi: MidiNote; voice: Voice; released: boolean}> = [];
/**
* All of the allocated voices for this synth.
@ -218,8 +218,8 @@ export class PolySynth<Voice extends Monophonic<any> = Synth> extends Instrument
const voice = this._getNextAvailableVoice();
if (voice) {
voice.triggerAttack(note, time, velocity);
this._activeVoices.unshift({
midi: midiNote, voice,
this._activeVoices.push({
midi: midiNote, voice, released: false,
});
this.log("triggerAttack", note, time);
}
@ -232,10 +232,14 @@ export class PolySynth<Voice extends Monophonic<any> = Synth> extends Instrument
private _triggerRelease(notes: Frequency[], time: Seconds): void {
notes.forEach(note => {
const midiNote = new MidiClass(this.context, note).toMidi();
const voice = this._getActiveVoice(midiNote);
if (voice) {
// trigger release on that note
voice.triggerRelease(time);
const events = this._activeVoices.filter(({ midi, released }) => midi === midiNote && !released);
if (events.length) {
events.forEach(e => {
// trigger release on that note
e.voice.triggerRelease(time);
// mark it as released
e.released = true;
});
this.log("triggerRelease", note, time);
}
});