Mirrors/Tone.js
2
0
Fork 0
mirror of https://github.com/Tonejs/Tone.js synced 2024-11-15 08:17:07 +00:00
Code Issues Projects Releases Packages Wiki Activity

Using GainNode instead of gain

Browse source 
fixes #299
This commit is contained in:
Yotam Mann 2019-09-29 10:30:57 -04:00
parent 410098c075
commit b379a20b6d
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Tone/component/filter/FeedbackCombFilter.ts
View file

@ -14,6 +14,10 @@ export interface FeedbackCombFilterOptions extends ToneAudioNodeOptions {
/**
* Comb filters are basic building blocks for physical modeling. Read more
* about comb filters on [CCRMA's website](https://ccrma.stanford.edu/~jos/pasp/Feedback_Comb_Filters.html).
*
* This comb filter is implemented with the AudioWorkletNode which allows it to have feedback delays less than the
* Web Audio processing block of 128 samples. There is a polyfill for browsers that don't yet support the
* AudioWorkletNode, but it will add some latency and have slower performance than the AudioWorkletNode.
* @category Component
*/
export class FeedbackCombFilter extends ToneAudioWorklet<FeedbackCombFilterOptions> {
@ -54,7 +58,7 @@ export class FeedbackCombFilter extends ToneAudioWorklet<FeedbackCombFilterOptio
this.input = new Gain({ context: this.context });
this.output = new Gain({ context: this.context });
const dummyParam = new Gain({ context: this.context });
const dummyParam = this.context.createGain();
this.delayTime = new Param<Time>({
context: this.context,