Mirrors/Tone.js
2
0
Fork 0
mirror of https://github.com/Tonejs/Tone.js synced 2025-01-14 04:43:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

renamed Signal methods

Browse source 
setCurrentValueNow -> setRampPoint, linearRampToValueNow ->
linearRampToValue
This commit is contained in:
Yotam Mann 2015-08-21 15:02:33 -04:00
parent ec400401c7
commit 7cb373635d
2 changed files with 19 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
CHANGELOG.md
View file

@ -1,8 +1,11 @@
### r6 ### r6
* Added PitchShift Effect. * Added PitchShift and Vibrato Effect.
* Added Timeline/TimelineState/TimelineSignal which keeps track of the state in the future * Added Timeline/TimelineState/TimelineSignal which keeps track of the state in the future
* removed `onended` event from Tone.Source * Clock uses requestAnimationFrame instead of ScriptProcessorNode
* Removed `onended` event from Tone.Source
* Refactored tests
* Renamed some Signal methods: exponentialRampToValueNow->exponentialRampToValue, setCurrentValueNow->setRampPoint
### r5 ### r5

27
Tone/signal/Signal.js
View file

@ -187,10 +187,9 @@ define(["Tone/core/Tone", "Tone/signal/WaveShaper", "Tone/core/Types"], function
* @param {number=} now (Optionally) pass the now value in. * @param {number=} now (Optionally) pass the now value in.
* @returns {Tone.Signal} this * @returns {Tone.Signal} this
*/ */
Tone.Signal.prototype.setCurrentValueNow = function(now){ Tone.Signal.prototype.setRampPoint = function(now){
now = this.defaultArg(now, this.now()); now = this.defaultArg(now, this.now());
var currentVal = this._value.value; var currentVal = this._value.value;
this.cancelScheduledValues(now);
this._value.setValueAtTime(currentVal, now); this._value.setValueAtTime(currentVal, now);
return this; return this;
}; };
@ -226,17 +225,18 @@ define(["Tone/core/Tone", "Tone/signal/WaveShaper", "Tone/core/Types"], function
/** /**
* Schedules an exponential continuous change in parameter value from * Schedules an exponential continuous change in parameter value from
* the current time and current value to the given value. * the current time and current value to the given value over the
* duration of the rampTime.
* *
* @param {number} value * @param {number} value The value to ramp to.
* @param {Time} rampTime the time that it takes the * @param {Time} rampTime the time that it takes the
* value to ramp from it's current value * value to ramp from it's current value
* @returns {Tone.Signal} this * @returns {Tone.Signal} this
* @example * @example
* //exponentially ramp to the value 2 over 4 seconds. * //exponentially ramp to the value 2 over 4 seconds.
* signal.exponentialRampToValueNow(2, 4); * signal.exponentialRampToValue(2, 4);
*/ */
Tone.Signal.prototype.exponentialRampToValueNow = function(value, rampTime){ Tone.Signal.prototype.exponentialRampToValue = function(value, rampTime){
var now = this.now(); var now = this.now();
// exponentialRampToValueAt cannot ever ramp from 0, apparently. // exponentialRampToValueAt cannot ever ramp from 0, apparently.
// More info: https://bugzilla.mozilla.org/show_bug.cgi?id=1125600#c2 // More info: https://bugzilla.mozilla.org/show_bug.cgi?id=1125600#c2
@ -248,19 +248,20 @@ define(["Tone/core/Tone", "Tone/signal/WaveShaper", "Tone/core/Types"], function
/** /**
* Schedules an linear continuous change in parameter value from * Schedules an linear continuous change in parameter value from
* the current time and current value to the given value at the given time. * the current time and current value to the given value over the
* duration of the rampTime.
* *
* @param {number} value * @param {number} value The value to ramp to.
* @param {Time} rampTime the time that it takes the * @param {Time} rampTime the time that it takes the
* value to ramp from it's current value * value to ramp from it's current value
* @returns {Tone.Signal} this * @returns {Tone.Signal} this
* @example * @example
* //linearly ramp to the value 4 over 3 seconds. * //linearly ramp to the value 4 over 3 seconds.
* signal.linearRampToValueNow(4, 3); * signal.linearRampToValue(4, 3);
*/ */
Tone.Signal.prototype.linearRampToValueNow = function(value, rampTime){ Tone.Signal.prototype.linearRampToValue = function(value, rampTime){
var now = this.now(); var now = this.now();
this.setCurrentValueNow(now); this.setRampPoint(now);
this.linearRampToValueAtTime(value, now + this.toSeconds(rampTime)); this.linearRampToValueAtTime(value, now + this.toSeconds(rampTime));
return this; return this;
}; };
@ -330,9 +331,9 @@ define(["Tone/core/Tone", "Tone/signal/WaveShaper", "Tone/core/Types"], function
Tone.Signal.prototype.rampTo = function(value, rampTime){ Tone.Signal.prototype.rampTo = function(value, rampTime){
rampTime = this.defaultArg(rampTime, 0); rampTime = this.defaultArg(rampTime, 0);
if (this.units === Tone.Type.Frequency || this.units === Tone.Type.BPM){ if (this.units === Tone.Type.Frequency || this.units === Tone.Type.BPM){
this.exponentialRampToValueNow(value, rampTime); this.exponentialRampToValue(value, rampTime);
} else { } else {
this.linearRampToValueNow(value, rampTime); this.linearRampToValue(value, rampTime);
} }
return this; return this;
}; };