Mirrors/Tone.js
2
0
Fork 0
mirror of https://github.com/Tonejs/Tone.js synced 2024-12-28 12:33:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #963 from Tonejs/revert-942-buffer-player-timekeeping

Browse source 
Revert "fix for AudioBufferSourceNode stop time miscalculation"
This commit is contained in:
Yotam Mann 2021-10-15 15:40:14 -04:00 committed by GitHub
commit 5c15c9517d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Tone/source/OneShotSource.ts
View file

@ -168,8 +168,7 @@ export abstract class OneShotSource<
// schedule the stop callback // schedule the stop callback
this._stopTime = this.toSeconds(time) + fadeOutTime; this._stopTime = this.toSeconds(time) + fadeOutTime;
const nowTime = this.now(); this._stopTime = Math.max(this._stopTime, this.context.currentTime);
this._stopTime = Math.max(this._stopTime, nowTime);
if (fadeOutTime > 0) { if (fadeOutTime > 0) {
// start the fade out curve at the given time // start the fade out curve at the given time
if (this._curve === "linear") { if (this._curve === "linear") {
@ -189,7 +188,7 @@ export abstract class OneShotSource<
this._curve === "exponential" ? fadeOutTime * 2 : 0; this._curve === "exponential" ? fadeOutTime * 2 : 0;
this._stopSource(this.now() + additionalTail); this._stopSource(this.now() + additionalTail);
this._onended(); this._onended();
}, this._stopTime - nowTime); }, this._stopTime - this.context.currentTime);
return this; return this;
} }