PKHeX/PKHeX.Core/Saves/Substructures/Gen7/Misc7.cs
Kurt 47071b41f3
Refactoring: Span-based value writes and method signatures (#3361)
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to.

`System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API.

The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder.

Other Fixes included:
- The Super Training UI for Gen6 has been reworked according to the latest block structure additions.
- Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list).
- Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-02 21:35:59 -08:00

76 lines
2.3 KiB
C#

using System;
using static System.Buffers.Binary.BinaryPrimitives;
namespace PKHeX.Core
{
public sealed class Misc7 : SaveBlock
{
public Misc7(SAV7SM sav, int offset) : base(sav) => Offset = offset;
public Misc7(SAV7USUM sav, int offset) : base(sav) => Offset = offset;
public uint Money
{
get => ReadUInt32LittleEndian(Data.AsSpan(Offset + 0x4));
set
{
if (value > 9_999_999)
value = 9_999_999;
WriteUInt32LittleEndian(Data.AsSpan(Offset + 0x4), value);
}
}
public uint Stamps
{
get => (ReadUInt32LittleEndian(Data.AsSpan(Offset + 0x08)) << 13) >> 17; // 15 stamps; discard top13, lowest4
set
{
uint flags = ReadUInt32LittleEndian(Data.AsSpan(Offset + 0x08)) & 0xFFF8000F;
flags |= (value & 0x7FFF) << 4;
WriteUInt32LittleEndian(SAV.Data.AsSpan(Offset + 0x08), flags);
}
}
public uint BP
{
get => ReadUInt32LittleEndian(Data.AsSpan(Offset + 0x11C));
set
{
if (value > 9999)
value = 9999;
WriteUInt32LittleEndian(Data.AsSpan(Offset + 0x11C), value);
}
}
public int Vivillon
{
get => Data[Offset + 0x130] & 0x1F;
set => Data[Offset + 0x130] = (byte)((Data[Offset + 0x130] & ~0x1F) | (value & 0x1F));
}
public uint StarterEncryptionConstant
{
get => ReadUInt32LittleEndian(Data.AsSpan(Offset + 0x148));
set => WriteUInt32LittleEndian(Data.AsSpan(Offset + 0x148), value);
}
public int DaysFromRefreshed
{
get => Data[Offset + 0x123];
set => Data[Offset + 0x123] = (byte)value;
}
public int GetSurfScore(int recordID)
{
if ((uint)recordID >= 4)
recordID = 0;
return ReadInt32LittleEndian(Data.AsSpan(Offset + 0x138 + (4 * recordID)));
}
public void SetSurfScore(int recordID, int score)
{
if ((uint)recordID >= 4)
recordID = 0;
WriteInt32LittleEndian(Data.AsSpan(Offset + 0x138 + (4 * recordID)), score);
}
}
}