mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-19 00:43:14 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
65 lines
No EOL
2.8 KiB
C#
65 lines
No EOL
2.8 KiB
C#
using System;
|
||
using static System.Buffers.Binary.BinaryPrimitives;
|
||
|
||
namespace PKHeX.Core
|
||
{
|
||
public sealed class PlayTime6 : SaveBlock
|
||
{
|
||
public PlayTime6(SaveFile sav, int offset) : base(sav) => Offset = offset;
|
||
|
||
public int PlayedHours
|
||
{
|
||
get => ReadUInt16LittleEndian(Data.AsSpan(Offset));
|
||
set => WriteUInt16LittleEndian(Data.AsSpan(Offset), (ushort)value);
|
||
}
|
||
|
||
public int PlayedMinutes
|
||
{
|
||
get => Data[Offset + 2];
|
||
set => Data[Offset + 2] = (byte)value;
|
||
}
|
||
|
||
public int PlayedSeconds
|
||
{
|
||
get => Data[Offset + 3];
|
||
set => Data[Offset + 3] = (byte)value;
|
||
}
|
||
|
||
private uint LastSaved { get => ReadUInt32LittleEndian(Data.AsSpan(Offset + 0x4)); set => WriteUInt32LittleEndian(Data.AsSpan(Offset + 0x4), value); }
|
||
private int LastSavedYear { get => (int)(LastSaved & 0xFFF); set => LastSaved = (LastSaved & 0xFFFFF000) | (uint)value; }
|
||
private int LastSavedMonth { get => (int)(LastSaved >> 12 & 0xF); set => LastSaved = (LastSaved & 0xFFFF0FFF) | ((uint)value & 0xF) << 12; }
|
||
private int LastSavedDay { get => (int)(LastSaved >> 16 & 0x1F); set => LastSaved = (LastSaved & 0xFFE0FFFF) | ((uint)value & 0x1F) << 16; }
|
||
private int LastSavedHour { get => (int)(LastSaved >> 21 & 0x1F); set => LastSaved = (LastSaved & 0xFC1FFFFF) | ((uint)value & 0x1F) << 21; }
|
||
private int LastSavedMinute { get => (int)(LastSaved >> 26 & 0x3F); set => LastSaved = (LastSaved & 0x03FFFFFF) | ((uint)value & 0x3F) << 26; }
|
||
public string LastSavedTime => $"{LastSavedYear:0000}-{LastSavedMonth:00}-{LastSavedDay:00} {LastSavedHour:00}ː{LastSavedMinute:00}"; // not :
|
||
|
||
public DateTime? LastSavedDate
|
||
{
|
||
get => !DateUtil.IsDateValid(LastSavedYear, LastSavedMonth, LastSavedDay)
|
||
? null
|
||
: new DateTime(LastSavedYear, LastSavedMonth, LastSavedDay, LastSavedHour, LastSavedMinute, 0);
|
||
set
|
||
{
|
||
// Only update the properties if a value is provided.
|
||
if (value.HasValue)
|
||
{
|
||
var dt = value.Value;
|
||
LastSavedYear = dt.Year;
|
||
LastSavedMonth = dt.Month;
|
||
LastSavedDay = dt.Day;
|
||
LastSavedHour = dt.Hour;
|
||
LastSavedMinute = dt.Minute;
|
||
}
|
||
else // Clear the date.
|
||
{
|
||
// If code tries to access MetDate again, null will be returned.
|
||
LastSavedYear = 0;
|
||
LastSavedMonth = 0;
|
||
LastSavedDay = 0;
|
||
LastSavedHour = 0;
|
||
LastSavedMinute = 0;
|
||
}
|
||
}
|
||
}
|
||
}
|
||
} |